Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2572743004: Move ios_helpers to sdk folder (Closed)

Created:
4 years ago by kthelgason
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move ios_helpers to sdk folder BUG=webrtc:5582 Review-Url: https://codereview.webrtc.org/2572743004 Cr-Commit-Position: refs/heads/master@{#15649} Committed: https://chromium.googlesource.com/external/webrtc/+/beafee3009ac5f17e9e18d9452c3ae8d29ca92b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -283 lines) Patch
M webrtc/modules/audio_device/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_device/ios/audio_device_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/audio_device/ios/helpers_ios.h View 1 chunk +0 lines, -77 lines 0 comments Download
D webrtc/modules/audio_device/ios/helpers_ios.mm View 1 chunk +0 lines, -197 lines 0 comments Download
M webrtc/sdk/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + webrtc/sdk/objc/Framework/Classes/helpers.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/sdk/objc/Framework/Classes/helpers.mm View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kthelgason
I'm splitting this work up into smaller CLs, of which this is the first. Next ...
4 years ago (2016-12-14 09:20:16 UTC) #2
henrika_webrtc
Great work. LGTM
4 years ago (2016-12-14 10:38:00 UTC) #3
tkchin_webrtc
On 2016/12/14 10:38:00, henrika_webrtc wrote: > Great work. > > LGTM lgtm
4 years ago (2016-12-15 22:29:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2572743004/1
4 years ago (2016-12-16 09:56:55 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-16 10:12:45 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/beafee3009ac5f17e9e18d945...

Powered by Google App Engine
This is Rietveld 408576698