Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2572703002: Delete method Pathname::url and base/urlencode* (Closed)

Created:
4 years ago by nisse-webrtc
Modified:
4 years ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete method Pathname::url and base/urlencode* BUG=webrtc:6424 Committed: https://crrev.com/bd6c6fa3090ead63c62e51bab257e98b9b990253 Cr-Commit-Position: refs/heads/master@{#15595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -333 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/base/pathutils.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/base/pathutils.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M webrtc/base/pathutils_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D webrtc/base/urlencode.h View 1 chunk +0 lines, -46 lines 0 comments Download
D webrtc/base/urlencode.cc View 1 chunk +0 lines, -181 lines 0 comments Download
D webrtc/base/urlencode_unittest.cc View 1 chunk +0 lines, -84 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
nisse-webrtc
4 years ago (2016-12-13 10:44:51 UTC) #2
pthatcher1
lgtm
4 years ago (2016-12-13 22:49:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2572703002/1
4 years ago (2016-12-14 09:41:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 09:42:57 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-14 09:43:14 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd6c6fa3090ead63c62e51bab257e98b9b990253
Cr-Commit-Position: refs/heads/master@{#15595}

Powered by Google App Engine
This is Rietveld 408576698