Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2572353003: Revert of Avoid precision loss in MedianSlopeEstimator from int64_t -> double conversion (Closed)

Created:
4 years ago by terelius
Modified:
4 years ago
Reviewers:
brandtr, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Avoid precision loss in MedianSlopeEstimator from int64_t -> double conversion (patchset #3 id:40001 of https://codereview.webrtc.org/2578543002/ ) Reason for revert: Multiple definitions of TestEstimator Original issue's description: > Pass arrival time as an int64_t rather than a double to the MedianSlopeEstimator to avoid precision loss. > > Also clean up the unit test. > > BUG=webrtc:6892 > > Committed: https://crrev.com/ebcbcc3b2451f5c4fb07f7b37815bd54f364d057 > Cr-Commit-Position: refs/heads/master@{#15634} TBR=brandtr@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6892 Committed: https://crrev.com/0bac07a89b58dcafbb27f8a25de3a38ae3a39704 Cr-Commit-Position: refs/heads/master@{#15635}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -45 lines) Patch
M webrtc/modules/congestion_controller/median_slope_estimator.h View 3 chunks +5 lines, -8 lines 0 comments Download
M webrtc/modules/congestion_controller/median_slope_estimator.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M webrtc/modules/congestion_controller/median_slope_estimator_unittest.cc View 1 chunk +68 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
terelius
Created Revert of Avoid precision loss in MedianSlopeEstimator from int64_t -> double conversion
4 years ago (2016-12-15 14:41:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2572353003/1
4 years ago (2016-12-15 14:41:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 14:41:42 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-15 14:41:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bac07a89b58dcafbb27f8a25de3a38ae3a39704
Cr-Commit-Position: refs/heads/master@{#15635}

Powered by Google App Engine
This is Rietveld 408576698