Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2571503002: Android GlTextureFrameBuffer: Re-attach texture in setSize (Closed)

Created:
4 years ago by magjed_webrtc
Modified:
3 years, 11 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android GlTextureFrameBuffer: Re-attach texture in setSize BUG=None Review-Url: https://codereview.webrtc.org/2571503002 Cr-Commit-Position: refs/heads/master@{#16110} Committed: https://chromium.googlesource.com/external/webrtc/+/9b96a172ed48dbf4618dd39bcd014eebe6de0310

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M webrtc/sdk/android/api/org/webrtc/GlTextureFrameBuffer.java View 2 chunks +15 lines, -11 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
magjed_webrtc
Sami - please take a look.
3 years, 11 months ago (2017-01-16 16:04:15 UTC) #10
sakal
lgtm Can you please verify this still works on Samsung Galaxy S3 mini? I think ...
3 years, 11 months ago (2017-01-17 08:25:16 UTC) #13
sakal
I just tested and it didn't seem to crash.
3 years, 11 months ago (2017-01-17 09:08:25 UTC) #14
sakal
I just tested and it didn't seem to crash.
3 years, 11 months ago (2017-01-17 09:08:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2571503002/20001
3 years, 11 months ago (2017-01-17 10:48:50 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 10:51:11 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/9b96a172ed48dbf4618dd39bc...

Powered by Google App Engine
This is Rietveld 408576698