| 
 | 
 | 
 Chromium Code Reviews
 Chromium Code Reviews Issue 
            2571503002:
    Android GlTextureFrameBuffer: Re-attach texture in setSize  (Closed)
    
  
    Issue 
            2571503002:
    Android GlTextureFrameBuffer: Re-attach texture in setSize  (Closed) 
  | Created: 4 years ago by magjed_webrtc Modified: 3 years, 11 months ago Reviewers: sakal CC: webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref: refs/heads/master Project: webrtc Visibility: Public. | DescriptionAndroid GlTextureFrameBuffer: Re-attach texture in setSize
BUG=None
Review-Url: https://codereview.webrtc.org/2571503002
Cr-Commit-Position: refs/heads/master@{#16110}
Committed: https://chromium.googlesource.com/external/webrtc/+/9b96a172ed48dbf4618dd39bcd014eebe6de0310
   Patch Set 1 #Patch Set 2 : Rebase #
 Messages
    Total messages: 20 (14 generated)
     
 The CQ bit was checked by magjed@webrtc.org to run a CQ dry run 
 Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/... 
 The CQ bit was unchecked by commit-bot@chromium.org 
 Dry run: This issue passed the CQ dry run. 
 The CQ bit was checked by magjed@webrtc.org to run a CQ dry run 
 Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/... 
 Description was changed from ========== Android GlTextureFrameBuffer: Re-attach texture in setSize BUG=webrtc:6470 ========== to ========== Android GlTextureFrameBuffer: Re-attach texture in setSize BUG=webrtc:6470 ========== 
 magjed@webrtc.org changed reviewers: + sakal@webrtc.org 
 Description was changed from ========== Android GlTextureFrameBuffer: Re-attach texture in setSize BUG=webrtc:6470 ========== to ========== Android GlTextureFrameBuffer: Re-attach texture in setSize BUG=None ========== 
 Sami - please take a look. 
 The CQ bit was unchecked by commit-bot@chromium.org 
 Dry run: This issue passed the CQ dry run. 
 lgtm Can you please verify this still works on Samsung Galaxy S3 mini? I think it should be fine since the framebuffer is only bound after changing the texture size. 
 I just tested and it didn't seem to crash. 
 I just tested and it didn't seem to crash. 
 The CQ bit was checked by magjed@webrtc.org 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/... 
 CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484650118137530,
"parent_rev": "1fd08c1e67b0cce45ddbadf660fc368cf3aac1ae", "commit_rev":
"9b96a172ed48dbf4618dd39bcd014eebe6de0310"}
 
            
              
                Message was sent while issue was closed.
              
            
             Description was changed from ========== Android GlTextureFrameBuffer: Re-attach texture in setSize BUG=None ========== to ========== Android GlTextureFrameBuffer: Re-attach texture in setSize BUG=None Review-Url: https://codereview.webrtc.org/2571503002 Cr-Commit-Position: refs/heads/master@{#16110} Committed: https://chromium.googlesource.com/external/webrtc/+/9b96a172ed48dbf4618dd39bc... ========== 
 
            
              
                Message was sent while issue was closed.
              
            
             Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/9b96a172ed48dbf4618dd39bc... | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
