Fixing integer overflow when parsing bandwidth attribute.

Fixing integer overflow when parsing bandwidth attribute.

It's still valid SDP so just clamp it at INT_MAX.

BUG=chromium:648071
Committed: https://crrev.com/b2362577634de26df7e824f526b40ec623b7abfa
Cr-Commit-Position: refs/heads/master@{#15582}

[Taylor Brandstetter, 2016-12-13 23:08:28]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2016-12-13 23:58:05]

lgtm, with small suggestion

https://codereview.webrtc.org/2571073002/diff/1/webrtc/api/webrtcsdp.cc
File webrtc/api/webrtcsdp.cc (right):

https://codereview.webrtc.org/2571073002/diff/1/webrtc/api/webrtcsdp.cc#newco...
webrtc/api/webrtcsdp.cc:2601: media_desc->set_bandwidth(b < INT_MAX / 1000 ? b *
1000 : INT_MAX);
Can you put a paren around the thing before "?"?  Thanks.    That would just
make it a bit easier to read.  

Actually, this might be even a bit easier to read:

int max_b = INT_MAX/1000; 
if (b > max_b) {
  b = max_b;
}
media_desc->set_bandwidth(b * 1000);

[Taylor Brandstetter, 2016-12-14 00:17:01]

https://codereview.webrtc.org/2571073002/diff/1/webrtc/api/webrtcsdp.cc
File webrtc/api/webrtcsdp.cc (right):

https://codereview.webrtc.org/2571073002/diff/1/webrtc/api/webrtcsdp.cc#newco...
webrtc/api/webrtcsdp.cc:2601: media_desc->set_bandwidth(b < INT_MAX / 1000 ? b *
1000 : INT_MAX);
On 2016/12/13 23:58:05, pthatcher1 wrote:
> Can you put a paren around the thing before "?"?  Thanks.    That would just
> make it a bit easier to read.  
> 
> Actually, this might be even a bit easier to read:
> 
> int max_b = INT_MAX/1000; 
> if (b > max_b) {
>   b = max_b;
> }
> media_desc->set_bandwidth(b * 1000);

Done (but using std::min).

[Taylor Brandstetter, 2016-12-14 00:17:05]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2016-12-14 00:17:05]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2571073002/#ps20001 (title:
"Making code more readable.")

[commit-bot: I haz the power, 2016-12-14 00:17:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-14 00:37:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481674625222230,
"parent_rev": "bc6b1e02c2c7ab29b5d0e39e8c64173018c95934", "commit_rev":
"b10d4cc2ef66b9531baf5e85163d6bbe6f711678"}

[commit-bot: I haz the power, 2016-12-14 00:37:09]

Description was changed from

==========
Fixing integer overflow when parsing bandwidth attribute.

It's still valid SDP so just clamp it at INT_MAX.

BUG=chromium:648071
==========

to

==========
Fixing integer overflow when parsing bandwidth attribute.

It's still valid SDP so just clamp it at INT_MAX.

BUG=chromium:648071

Review-Url: https://codereview.webrtc.org/2571073002
==========

[commit-bot: I haz the power, 2016-12-14 00:37:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 00:37:23]

Description was changed from

==========
Fixing integer overflow when parsing bandwidth attribute.

It's still valid SDP so just clamp it at INT_MAX.

BUG=chromium:648071

Review-Url: https://codereview.webrtc.org/2571073002
==========

to

==========
Fixing integer overflow when parsing bandwidth attribute.

It's still valid SDP so just clamp it at INT_MAX.

BUG=chromium:648071

Committed: https://crrev.com/b2362577634de26df7e824f526b40ec623b7abfa
Cr-Commit-Position: refs/heads/master@{#15582}
==========

[commit-bot: I haz the power, 2016-12-14 00:37:24]

Patchset 2 (id:??) landed as
https://crrev.com/b2362577634de26df7e824f526b40ec623b7abfa
Cr-Commit-Position: refs/heads/master@{#15582}