Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1693)

Issue 2570803003: ParseCandidate(): Refactor to fix memcheck false positive. (Closed)

Created:
4 years ago by hnsl1
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

ParseCandidate(): Refactor to fix memcheck false positive. Also make supported protocols explicit in check. Fix inconsistency where TLS_PROTOCOL_NAME was not exported. BUG=webrtc:6885 Committed: https://crrev.com/b68cc75f1959218970df168b4c1b6e724692ac39 Cr-Commit-Position: refs/heads/master@{#15577}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M webrtc/api/webrtcsdp.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M webrtc/p2p/base/port.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
hnsl1
Please review this CL which fixes a false positive regression in https://codereview.webrtc.org/2568833002/
4 years ago (2016-12-13 17:49:35 UTC) #4
Taylor Brandstetter
lgtm. I had no idea this kind of thing could trip up memcheck; good to ...
4 years ago (2016-12-13 18:25:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2570803003/1
4 years ago (2016-12-13 18:28:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 18:33:46 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-13 18:33:54 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b68cc75f1959218970df168b4c1b6e724692ac39
Cr-Commit-Position: refs/heads/master@{#15577}

Powered by Google App Engine
This is Rietveld 408576698