Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2568883004:
Improvements to the reliability of the echo detector perf test. (Closed)
|
Created:
4 years ago by ivoc Modified:
4 years ago Reviewers:
peah-webrtc CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1 Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionImprovements to the reliability of the echo detector perf test.
BUG=chromium:673683
Committed: https://crrev.com/930959d261451af05c31db944ecc440808eb89f8
Cr-Commit-Position: refs/heads/master@{#15606}
Patch Set 1 #
Total comments: 8
Patch Set 2 : Added constant for batch size. #
Total comments: 2
Patch Set 3 : Introduced another const for the warmup batch size. #Messages
Total messages: 16 (7 generated)
Description was changed from ========== Improvements the reliability of the echo detector perf test. BUG=chromium:673683 ========== to ========== Improvements to the reliability of the echo detector perf test. BUG=chromium:673683 ==========
ivoc@webrtc.org changed reviewers: + peah@webrtc.org
Hi Per, PTAL at these improvements to the echo detector perf tests.
On 2016/12/13 15:22:31, ivoc wrote: > Hi Per, PTAL at these improvements to the echo detector perf tests.
https://codereview.webrtc.org/2568883004/diff/1/webrtc/modules/audio_processi... File webrtc/modules/audio_processing/residual_echo_detector_complexity_unittest.cc (right): https://codereview.webrtc.org/2568883004/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/residual_echo_detector_complexity_unittest.cc:53: if (frame_no >= 20 && frame_no % 20 == 0) { You should probably add a constant (or 2) for the 20s, as you use them on lines 65, 124 and 146 as well (also as 19=20-1). https://codereview.webrtc.org/2568883004/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/residual_echo_detector_complexity_unittest.cc:65: if (frame_no >= 20 && frame_no % 20 == 19) { Please add a constant (or 2) for the 20s. https://codereview.webrtc.org/2568883004/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/residual_echo_detector_complexity_unittest.cc:124: if (frame_no >= 20 && frame_no % 20 == 0) { Please add a constant (or 2) for the 20s. https://codereview.webrtc.org/2568883004/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/residual_echo_detector_complexity_unittest.cc:146: if (frame_no >= 20 && frame_no % 20 == 19) { Please add a constant (or 2) for the 20s.
Thanks for the comments. https://codereview.webrtc.org/2568883004/diff/1/webrtc/modules/audio_processi... File webrtc/modules/audio_processing/residual_echo_detector_complexity_unittest.cc (right): https://codereview.webrtc.org/2568883004/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/residual_echo_detector_complexity_unittest.cc:53: if (frame_no >= 20 && frame_no % 20 == 0) { On 2016/12/14 09:00:04, peah-webrtc wrote: > You should probably add a constant (or 2) for the 20s, as you use them on lines > 65, 124 and 146 as well (also as 19=20-1). Good idea, done. https://codereview.webrtc.org/2568883004/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/residual_echo_detector_complexity_unittest.cc:65: if (frame_no >= 20 && frame_no % 20 == 19) { On 2016/12/14 09:00:04, peah-webrtc wrote: > Please add a constant (or 2) for the 20s. Done. https://codereview.webrtc.org/2568883004/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/residual_echo_detector_complexity_unittest.cc:124: if (frame_no >= 20 && frame_no % 20 == 0) { On 2016/12/14 09:00:04, peah-webrtc wrote: > Please add a constant (or 2) for the 20s. Done. https://codereview.webrtc.org/2568883004/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/residual_echo_detector_complexity_unittest.cc:146: if (frame_no >= 20 && frame_no % 20 == 19) { On 2016/12/14 09:00:04, peah-webrtc wrote: > Please add a constant (or 2) for the 20s. Done.
Great! lgtm https://codereview.webrtc.org/2568883004/diff/20001/webrtc/modules/audio_proc... File webrtc/modules/audio_processing/residual_echo_detector_complexity_unittest.cc (right): https://codereview.webrtc.org/2568883004/diff/20001/webrtc/modules/audio_proc... webrtc/modules/audio_processing/residual_echo_detector_complexity_unittest.cc:54: if (frame_no >= kProcessingBatchSize && I think this is good, but if needed you could separate the length of the warm-up phase from the batch size.
Thanks for reviewing! https://codereview.webrtc.org/2568883004/diff/20001/webrtc/modules/audio_proc... File webrtc/modules/audio_processing/residual_echo_detector_complexity_unittest.cc (right): https://codereview.webrtc.org/2568883004/diff/20001/webrtc/modules/audio_proc... webrtc/modules/audio_processing/residual_echo_detector_complexity_unittest.cc:54: if (frame_no >= kProcessingBatchSize && On 2016/12/14 09:54:32, peah-webrtc wrote: > I think this is good, but if needed you could separate the length of the warm-up > phase from the batch size. Done.
The CQ bit was checked by ivoc@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from peah@webrtc.org Link to the patchset: https://codereview.webrtc.org/2568883004/#ps40001 (title: "Introduced another const for the warmup batch size.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481722204522980,
"parent_rev": "29e2ea28da8249161ac5ca3c5801a4d5744288de", "commit_rev":
"34ba72f1f4397a68ddaba7f2cf68311ecbe06c89"}
Message was sent while issue was closed.
Description was changed from ========== Improvements to the reliability of the echo detector perf test. BUG=chromium:673683 ========== to ========== Improvements to the reliability of the echo detector perf test. BUG=chromium:673683 Review-Url: https://codereview.webrtc.org/2568883004 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Improvements to the reliability of the echo detector perf test. BUG=chromium:673683 Review-Url: https://codereview.webrtc.org/2568883004 ========== to ========== Improvements to the reliability of the echo detector perf test. BUG=chromium:673683 Committed: https://crrev.com/930959d261451af05c31db944ecc440808eb89f8 Cr-Commit-Position: refs/heads/master@{#15606} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/930959d261451af05c31db944ecc440808eb89f8 Cr-Commit-Position: refs/heads/master@{#15606} |
