Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2568553002: Add SSRC to RtpEncodingParameters for audio. (Closed)

Created:
4 years ago by Taylor Brandstetter
Modified:
4 years ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add SSRC to RtpEncodingParameters for audio. Was added for video initially, but not for audio. BUG=webrtc:6862 Committed: https://crrev.com/cb44343006c1fcf282ae3ce55640ba297be2ad74 Cr-Commit-Position: refs/heads/master@{#15552}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M webrtc/media/engine/webrtcvoiceengine.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 2 chunks +17 lines, -0 lines 2 comments Download

Messages

Total messages: 11 (5 generated)
Taylor Brandstetter
PTAL (by the way, are you still the best reviewer for this code?)
4 years ago (2016-12-09 19:48:51 UTC) #2
the sun
LGTM Yes, I probably have the most knowledge of this piece of the puzzle right ...
4 years ago (2016-12-12 08:59:19 UTC) #3
Taylor Brandstetter
https://codereview.webrtc.org/2568553002/diff/1/webrtc/media/engine/webrtcvoiceengine_unittest.cc File webrtc/media/engine/webrtcvoiceengine_unittest.cc (right): https://codereview.webrtc.org/2568553002/diff/1/webrtc/media/engine/webrtcvoiceengine_unittest.cc#newcode1160 webrtc/media/engine/webrtcvoiceengine_unittest.cc:1160: webrtc::RtpParameters rtp_parameters = On 2016/12/12 08:59:19, the sun wrote: ...
4 years ago (2016-12-12 18:50:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2568553002/1
4 years ago (2016-12-12 18:50:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 19:12:40 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-12 19:26:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb44343006c1fcf282ae3ce55640ba297be2ad74
Cr-Commit-Position: refs/heads/master@{#15552}

Powered by Google App Engine
This is Rietveld 408576698