Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2568043002: Making audio network adaptor config proto a JAVA package. (Closed)

Created:
4 years ago by minyue-webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Making audio network adaptor config proto a JAVA package. BUG=webrtc:6303 Committed: https://crrev.com/1354901663dc2fd2169a87a9da2fb6b4e6e107d9 Cr-Commit-Position: refs/heads/master@{#15555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webrtc/modules/audio_coding/audio_network_adaptor/config.proto View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
minyue-webrtc
Hi Henrik and Michael, Please help review this tiny CL. Thanks!
4 years ago (2016-12-12 09:15:17 UTC) #3
michaelt
lgtm
4 years ago (2016-12-12 10:32:25 UTC) #4
hlundin-webrtc
I have no idea what the code does, so you have my rubber-stamp LGTM. But, ...
4 years ago (2016-12-12 21:42:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2568043002/1
4 years ago (2016-12-12 21:48:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 22:06:23 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-12 22:06:29 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1354901663dc2fd2169a87a9da2fb6b4e6e107d9
Cr-Commit-Position: refs/heads/master@{#15555}

Powered by Google App Engine
This is Rietveld 408576698