Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issue 2567143003: Delete rtc::linked_ptr. Only use, in statstypes.h, replaced bu std::unique_ptr. (Closed)

Created:
4 years ago by nisse-webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete rtc::linked_ptr. Only use, in statstypes.h, replaced with std::unique_ptr. BUG=webrtc:6424 Committed: https://crrev.com/36f74e55792cae19db8b222c29aa38d6e0eb1225 Cr-Commit-Position: refs/heads/master@{#15588}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -130 lines) Patch
M webrtc/api/statstypes.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/cryptstring.h View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/base/linked_ptr.h View 1 chunk +0 lines, -125 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
nisse-webrtc
Hi, this change seems to pass all tests, but it's unclear to me if it ...
4 years ago (2016-12-13 11:37:03 UTC) #7
the sun
lgtm
4 years ago (2016-12-13 11:53:17 UTC) #8
pthatcher1
lgtm
4 years ago (2016-12-13 23:21:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2567143003/1
4 years ago (2016-12-14 07:34:43 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 07:36:21 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/36f74e55792cae19db8b222c29aa38d6e0eb1225 Cr-Commit-Position: refs/heads/master@{#15588}
4 years ago (2016-12-14 07:36:32 UTC) #16
nisse-webrtc
4 years ago (2016-12-14 08:06:17 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2576673002/ by nisse@webrtc.org.

The reason for reverting is: The change from rtc::linked_ptr to std::unique_ptr
broke a downstream project..

Powered by Google App Engine
This is Rietveld 408576698