Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2566833002: Don't allow changing ICE pool size after SetLocalDescription. (Closed)

Created:
4 years ago by Taylor Brandstetter
Modified:
4 years ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't allow changing ICE pool size after SetLocalDescription. This was the decision at IETF 97 (see: https://github.com/rtcweb-wg/jsep/issues/381). It's simpler to not allow this (since there's no real need for it) rather than try to decide complex rules for it. BUG=webrtc:6864 Committed: https://crrev.com/6de92f9255b8746ad1be920fa508c19cb71dea63 Cr-Commit-Position: refs/heads/master@{#15559}

Patch Set 1 #

Patch Set 2 : Allow PortAllocator::SetConfiguration to fail and log an error; shouldn't trigger DCHECK on invalid… #

Patch Set 3 : . #

Patch Set 4 : Fixing signed/unsigned compare warning. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -39 lines) Patch
M webrtc/api/peerconnection.cc View 1 2 3 chunks +12 lines, -4 lines 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M webrtc/p2p/base/portallocator.h View 3 chunks +5 lines, -7 lines 0 comments Download
M webrtc/p2p/base/portallocator.cc View 1 2 3 2 chunks +29 lines, -12 lines 0 comments Download
M webrtc/p2p/base/portallocator_unittest.cc View 4 chunks +21 lines, -16 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Taylor Brandstetter
PTAL Peter. This was the last major thing holding me back from making ICE candidate ...
4 years ago (2016-12-10 09:33:58 UTC) #2
pthatcher1
lgtm
4 years ago (2016-12-12 23:40:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2566833002/40001
4 years ago (2016-12-13 02:03:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/20907)
4 years ago (2016-12-13 02:16:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2566833002/60001
4 years ago (2016-12-13 02:20:51 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-13 02:49:37 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-13 02:49:43 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6de92f9255b8746ad1be920fa508c19cb71dea63
Cr-Commit-Position: refs/heads/master@{#15559}

Powered by Google App Engine
This is Rietveld 408576698