Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2566223007:
Autoroller: Add --ignore-unclean-workdir flag (Closed)
|
Created:
4 years ago by kjellander_webrtc Modified:
4 years ago Reviewers:
phoglund CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAutoroller: Add --ignore-unclean-workdir flag
Add a flag that makes the script more useful for local development, when
you normally develop on a local branch.
BUG=webrtc:5006
NOTRY=True
Committed: https://crrev.com/665da2885737160eb402119893bcb0d0f249de5f
Cr-Commit-Position: refs/heads/master@{#15602}
Patch Set 1 : _ #
Total comments: 2
Patch Set 2 : Renamed to --ignore-unclean-workdir #Messages
Total messages: 16 (10 generated)
Description was changed from ========== Convert build/ and buildtools/ to regular DEPS entries. BUG=webrtc:5006 ========== to ========== Autoroller: Add --ignore_changes flag Add a flag that makes the script more useful for local development, when you normally develop on a local branch. BUG=webrtc:5006 ==========
kjellander@webrtc.org changed reviewers: + phoglund@webrtc.org
Patchset #1 (id:1) has been deleted
Description was changed from ========== Autoroller: Add --ignore_changes flag Add a flag that makes the script more useful for local development, when you normally develop on a local branch. BUG=webrtc:5006 ========== to ========== Autoroller: Add --ignore_changes flag Add a flag that makes the script more useful for local development, when you normally develop on a local branch. BUG=webrtc:5006 NOTRY=True ==========
lgtm https://codereview.webrtc.org/2566223007/diff/20001/tools/autoroller/roll_chr... File tools/autoroller/roll_chromium_revision.py (right): https://codereview.webrtc.org/2566223007/diff/20001/tools/autoroller/roll_chr... tools/autoroller/roll_chromium_revision.py:452: p.add_argument('-i', '--ignore-changes', action='store_true', default=False, ignore-unclean-workdir?
Description was changed from ========== Autoroller: Add --ignore_changes flag Add a flag that makes the script more useful for local development, when you normally develop on a local branch. BUG=webrtc:5006 NOTRY=True ========== to ========== Autoroller: Add --ignore-unclean-workdir flag Add a flag that makes the script more useful for local development, when you normally develop on a local branch. BUG=webrtc:5006 NOTRY=True ==========
https://codereview.webrtc.org/2566223007/diff/20001/tools/autoroller/roll_chr... File tools/autoroller/roll_chromium_revision.py (right): https://codereview.webrtc.org/2566223007/diff/20001/tools/autoroller/roll_chr... tools/autoroller/roll_chromium_revision.py:452: p.add_argument('-i', '--ignore-changes', action='store_true', default=False, On 2016/12/14 10:24:50, phoglund wrote: > ignore-unclean-workdir? That's better; I changed it.
The CQ bit was checked by kjellander@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from phoglund@webrtc.org Link to the patchset: https://codereview.webrtc.org/2566223007/#ps40001 (title: "Renamed to --ignore-unclean-workdir")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481716449372750,
"parent_rev": "78820483f81f95d73cc7e85855e9a4b93b5b340f", "commit_rev":
"5d242a7fe22895a23a6aab1f84218cb56fe2ece5"}
Message was sent while issue was closed.
Description was changed from ========== Autoroller: Add --ignore-unclean-workdir flag Add a flag that makes the script more useful for local development, when you normally develop on a local branch. BUG=webrtc:5006 NOTRY=True ========== to ========== Autoroller: Add --ignore-unclean-workdir flag Add a flag that makes the script more useful for local development, when you normally develop on a local branch. BUG=webrtc:5006 NOTRY=True Review-Url: https://codereview.webrtc.org/2566223007 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Autoroller: Add --ignore-unclean-workdir flag Add a flag that makes the script more useful for local development, when you normally develop on a local branch. BUG=webrtc:5006 NOTRY=True Review-Url: https://codereview.webrtc.org/2566223007 ========== to ========== Autoroller: Add --ignore-unclean-workdir flag Add a flag that makes the script more useful for local development, when you normally develop on a local branch. BUG=webrtc:5006 NOTRY=True Committed: https://crrev.com/665da2885737160eb402119893bcb0d0f249de5f Cr-Commit-Position: refs/heads/master@{#15602} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/665da2885737160eb402119893bcb0d0f249de5f Cr-Commit-Position: refs/heads/master@{#15602} |
