RTCIceCandidatePairStats.requestsReceived defined by RTCStatsCollector.

RTCIceCandidatePairStats.requestsReceived defined by RTCStatsCollector.

Spec: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-requestsreceived

BUG=chromium:633550
Committed: https://crrev.com/d82f5125b7cc00ddd16430b0d4e1f8cfde51ac17
Cr-Commit-Position: refs/heads/master@{#15506}

[hbos, 2016-12-08 14:53:43]

The CQ bit was checked by hbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 14:53:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[hbos, 2016-12-08 14:55:13]

hbos@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, hta@webrtc.org

[hbos, 2016-12-08 14:55:13]

Please take a look, deadbeef & hta

[hbos, 2016-12-08 14:59:37]

https://codereview.webrtc.org/2565463002/diff/1/webrtc/api/rtcstatscollector.cc
File webrtc/api/rtcstatscollector.cc (right):

https://codereview.webrtc.org/2565463002/diff/1/webrtc/api/rtcstatscollector....
webrtc/api/rtcstatscollector.cc:638:
static_cast<uint64_t>(info.recv_ping_requests);
This is what the old getStats uses for googCandidatePair.requestsReceived

[commit-bot: I haz the power, 2016-12-08 15:28:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 15:28:17]

Dry run: This issue passed the CQ dry run.

[Taylor Brandstetter, 2016-12-08 21:36:10]

I'm still not clear on how we're supposed to differentiate connectivity requests
from consent requests, but for now this is better than nothing. lgtm

[Taylor Brandstetter, 2016-12-08 22:02:24]

On 2016/12/08 21:36:10, Taylor Brandstetter wrote:
> I'm still not clear on how we're supposed to differentiate connectivity
requests
> from consent requests, but for now this is better than nothing. lgtm

Here's an issue I filed for this, by the way:
https://github.com/w3c/webrtc-stats/issues/96

[hta-webrtc, 2016-12-09 09:50:36]

lgtm

[hbos, 2016-12-09 12:10:38]

The CQ bit was checked by hbos@webrtc.org

[commit-bot: I haz the power, 2016-12-09 12:10:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-09 12:12:39]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481285438304950, "parent_rev":
"38adf2ad6978ebe4d5b385ca7dda8ce71bfbd433", "commit_rev":
"e5951e012cc9fbb913d25d60fa42a502bec66cbf"}

[commit-bot: I haz the power, 2016-12-09 12:12:41]

Description was changed from

==========
RTCIceCandidatePairStats.requestsReceived defined by RTCStatsCollector.

Spec:
https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-requestsrece...

BUG=chromium:633550
==========

to

==========
RTCIceCandidatePairStats.requestsReceived defined by RTCStatsCollector.

Spec:
https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-requestsrece...

BUG=chromium:633550

Review-Url: https://codereview.webrtc.org/2565463002
==========

[commit-bot: I haz the power, 2016-12-09 12:12:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-09 12:12:48]

Description was changed from

==========
RTCIceCandidatePairStats.requestsReceived defined by RTCStatsCollector.

Spec:
https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-requestsrece...

BUG=chromium:633550

Review-Url: https://codereview.webrtc.org/2565463002
==========

to

==========
RTCIceCandidatePairStats.requestsReceived defined by RTCStatsCollector.

Spec:
https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-requestsrece...

BUG=chromium:633550

Committed: https://crrev.com/d82f5125b7cc00ddd16430b0d4e1f8cfde51ac17
Cr-Commit-Position: refs/heads/master@{#15506}
==========

[commit-bot: I haz the power, 2016-12-09 12:12:49]

Patchset 1 (id:??) landed as
https://crrev.com/d82f5125b7cc00ddd16430b0d4e1f8cfde51ac17
Cr-Commit-Position: refs/heads/master@{#15506}

[hbos, 2016-12-09 12:42:20]

On 2016/12/08 22:02:24, Taylor Brandstetter wrote:
> On 2016/12/08 21:36:10, Taylor Brandstetter wrote:
> > I'm still not clear on how we're supposed to differentiate connectivity
> requests
> > from consent requests, but for now this is better than nothing. lgtm
> 
> Here's an issue I filed for this, by the way:
> https://github.com/w3c/webrtc-stats/issues/96

Meaning we now have a bug that requestsReceived will keep incrementing after
connection has been established, when it's suppose to stop incrementing and
start incrementing consentRequestsReceived instead. Correct?

[hta-webrtc, 2016-12-09 13:42:15]

On 2016/12/09 12:42:20, hbos wrote:
> On 2016/12/08 22:02:24, Taylor Brandstetter wrote:
> > On 2016/12/08 21:36:10, Taylor Brandstetter wrote:
> > > I'm still not clear on how we're supposed to differentiate connectivity
> > requests
> > > from consent requests, but for now this is better than nothing. lgtm
> > 
> > Here's an issue I filed for this, by the way:
> > https://github.com/w3c/webrtc-stats/issues/96
> 
> Meaning we now have a bug that requestsReceived will keep incrementing after
> connection has been established, when it's suppose to stop incrementing and
> start incrementing consentRequestsReceived instead. Correct?

https://github.com/w3c/webrtc-stats/issues/96 tracks trying to clarify this in
the spec.