Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2565353002:
Wire-up audio BWE with overhead. (Closed)
DescriptionWire-up audio BWE with overhead.
BUG=webrtc:6638
Committed: https://crrev.com/bf65be543502873987e7f8f31b63a914ac4126de
Cr-Commit-Position: refs/heads/master@{#15632}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Response to comments. #
Total comments: 1
Messages
Total messages: 22 (12 generated)
The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Wire-up audio BWE with overhead. BUG=webrtc:6638 ========== to ========== Wire-up audio BWE with overhead. BUG=webrtc:6638 ==========
michaelt@webrtc.org changed reviewers: + minyue@webrtc.org, stefan@webrtc.org
Here a CL for the missing wire up of audio bwe with overhead.
lgtm
minyue@webrtc.org changed reviewers: + solenberg@webrtc.org
add Fredrik for owner's approval.
lgtm https://codereview.webrtc.org/2565353002/diff/1/webrtc/voice_engine/channel.cc File webrtc/voice_engine/channel.cc (right): https://codereview.webrtc.org/2565353002/diff/1/webrtc/voice_engine/channel.c... webrtc/voice_engine/channel.cc:2887: if (*encoder) nit: {} for one liners in this file
https://codereview.webrtc.org/2565353002/diff/1/webrtc/voice_engine/channel.cc File webrtc/voice_engine/channel.cc (right): https://codereview.webrtc.org/2565353002/diff/1/webrtc/voice_engine/channel.c... webrtc/voice_engine/channel.cc:2887: if (*encoder) On 2016/12/13 16:46:02, the sun wrote: > nit: {} for one liners in this file Done.
Hi Stefan, This is really simple. Would you take a look when you have a minute?
lgtm https://codereview.webrtc.org/2565353002/diff/20001/webrtc/voice_engine/chann... File webrtc/voice_engine/channel.h (right): https://codereview.webrtc.org/2565353002/diff/20001/webrtc/voice_engine/chann... webrtc/voice_engine/channel.h:420: // From OverheadObserver in the RTP/RTCP module End with "."
The CQ bit was checked by michaelt@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from solenberg@webrtc.org, minyue@webrtc.org Link to the patchset: https://codereview.webrtc.org/2565353002/#ps20001 (title: "Response to comments.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481807589935990,
"parent_rev": "867926ac9ce54fb38447e15cd794eed955aa4855", "commit_rev":
"b1c2bc6fb1d9af86d8c600effc610907e42d7e00"}
Message was sent while issue was closed.
Description was changed from ========== Wire-up audio BWE with overhead. BUG=webrtc:6638 ========== to ========== Wire-up audio BWE with overhead. BUG=webrtc:6638 Review-Url: https://codereview.webrtc.org/2565353002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Wire-up audio BWE with overhead. BUG=webrtc:6638 Review-Url: https://codereview.webrtc.org/2565353002 ========== to ========== Wire-up audio BWE with overhead. BUG=webrtc:6638 Committed: https://crrev.com/bf65be543502873987e7f8f31b63a914ac4126de Cr-Commit-Position: refs/heads/master@{#15632} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/bf65be543502873987e7f8f31b63a914ac4126de Cr-Commit-Position: refs/heads/master@{#15632} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
