Wire up H264 fmtp sprop-parameter-sets with H264SpsPpsTracker.

Wire up H264 fmtp  sprop-parameter-sets with H264SpsPpsTracker.

To avoid making this CL large unittests will be added in a followup CL.

BUG=webrtc:5948
patch from issue 2570073002 at patchset 20001 (http://crrev.com/2570073002#ps20001)

Review-Url: https://codereview.webrtc.org/2565173009
Cr-Commit-Position: refs/heads/master@{#15710}
Committed: https://chromium.googlesource.com/external/webrtc/+/022b54e86a538236b6a3cb97b80dfa1b3e3d5c56

[philipel, 2016-12-14 17:59:51]

philipel@webrtc.org changed reviewers:
+ johan@webrtc.org

[philipel, 2016-12-14 18:03:35]

Description was changed from

==========
Continuation of "Wire up H264 fmtp  sprop-parameter-sets with
H264SpsPpsTracker."

BUG=webrtc:5948

patch from issue 2570073002 at patchset 20001
(http://crrev.com/2570073002#ps20001)
==========

to

==========
Continuation of "Wire up H264 fmtp  sprop-parameter-sets with
H264SpsPpsTracker."

TODO:
 - Unittests for H264SpsPpsTracker::InsertSpsPps.
 - Unittests for RtpStreamReceiver::AddReceiveCodec
 - Unittests for RtpStreamReceiver::OnReceivedPayloadData

BUG=webrtc:5948

patch from issue 2570073002 at patchset 20001
(http://crrev.com/2570073002#ps20001)
==========

[philipel, 2016-12-16 10:38:07]

Description was changed from

==========
Continuation of "Wire up H264 fmtp  sprop-parameter-sets with
H264SpsPpsTracker."

TODO:
 - Unittests for H264SpsPpsTracker::InsertSpsPps.
 - Unittests for RtpStreamReceiver::AddReceiveCodec
 - Unittests for RtpStreamReceiver::OnReceivedPayloadData

BUG=webrtc:5948

patch from issue 2570073002 at patchset 20001
(http://crrev.com/2570073002#ps20001)
==========

to

==========
Continuation of "Wire up H264 fmtp  sprop-parameter-sets with
H264SpsPpsTracker."

To avoid making this CL large unittests will be added in a followup CL.

BUG=webrtc:5948

patch from issue 2570073002 at patchset 20001
(http://crrev.com/2570073002#ps20001)
==========

[philipel, 2016-12-16 10:39:04]

philipel@webrtc.org changed reviewers:
+ stefan@webrtc.org

[philipel, 2016-12-16 10:39:45]

Description was changed from

==========
Continuation of "Wire up H264 fmtp  sprop-parameter-sets with
H264SpsPpsTracker."

To avoid making this CL large unittests will be added in a followup CL.

BUG=webrtc:5948

patch from issue 2570073002 at patchset 20001
(http://crrev.com/2570073002#ps20001)
==========

to

==========
Wire up H264 fmtp  sprop-parameter-sets with H264SpsPpsTracker.

To avoid making this CL large unittests will be added in a followup CL.

BUG=webrtc:5948

patch from issue 2570073002 at patchset 20001
(http://crrev.com/2570073002#ps20001)
==========

[stefan-webrtc, 2016-12-19 12:05:23]

https://codereview.webrtc.org/2565173009/diff/40001/webrtc/video/rtp_stream_r...
File webrtc/video/rtp_stream_receiver.cc (right):

https://codereview.webrtc.org/2565173009/diff/40001/webrtc/video/rtp_stream_r...
webrtc/video/rtp_stream_receiver.cc:273: if (!received_rtp_packet_) {
Can't the payload type change in theory since we support both high and baseline
profiles?

https://codereview.webrtc.org/2565173009/diff/40001/webrtc/video/rtp_stream_r...
webrtc/video/rtp_stream_receiver.cc:674: LOG(LS_INFO) << "Found out of band
supplied codec paramters for"
codec parameters

https://codereview.webrtc.org/2565173009/diff/40001/webrtc/video/rtp_stream_r...
File webrtc/video/rtp_stream_receiver.h (right):

https://codereview.webrtc.org/2565173009/diff/40001/webrtc/video/rtp_stream_r...
webrtc/video/rtp_stream_receiver.h:205: std::map<uint8_t, std::map<std::string,
std::string>> pt_codec_params_;
Clarify what the mapping is with a comment. "Map from payload type to map from
..."

[johan, 2016-12-19 12:27:27]

https://codereview.webrtc.org/2565173009/diff/40001/webrtc/video/rtp_stream_r...
File webrtc/video/rtp_stream_receiver.cc (right):

https://codereview.webrtc.org/2565173009/diff/40001/webrtc/video/rtp_stream_r...
webrtc/video/rtp_stream_receiver.cc:273: if (!received_rtp_packet_) {
On 2016/12/19 12:05:23, stefan-webrtc (holmer) wrote:
> Can't the payload type change in theory since we support both high and
baseline
> profiles?

The payload type represents what sender and receiver claim to support. That
*should* not change during a call. Also, Constrained Baseline Profile is a true
subset of High Profile, so I do not see a point in not using the High Profile pt
in the first place, when available on both ends. CBP and HP capabilities are
represented by profile-level-id FMTP in the SDP.

"Baseline Profile" without the "Constrained" is a slightly different story. But
both people and computers usually mean CBP, when saying BP.

We should double check on this question, but I think supporting a change of
payload type during a call makes things unnecessary complicated. Anyway maybe a
RTC_DCHECK_EQ on current and previous payload type could be a good idea.

[philipel, 2016-12-19 12:31:27]

https://codereview.webrtc.org/2565173009/diff/40001/webrtc/video/rtp_stream_r...
File webrtc/video/rtp_stream_receiver.cc (right):

https://codereview.webrtc.org/2565173009/diff/40001/webrtc/video/rtp_stream_r...
webrtc/video/rtp_stream_receiver.cc:273: if (!received_rtp_packet_) {
On 2016/12/19 12:05:23, stefan-webrtc (holmer) wrote:
> Can't the payload type change in theory since we support both high and
baseline
> profiles?

The assumption is that there is only one VideoReceiveStream per payload type.

https://codereview.webrtc.org/2565173009/diff/40001/webrtc/video/rtp_stream_r...
webrtc/video/rtp_stream_receiver.cc:674: LOG(LS_INFO) << "Found out of band
supplied codec paramters for"
On 2016/12/19 12:05:23, stefan-webrtc (holmer) wrote:
> codec parameters

Done.

https://codereview.webrtc.org/2565173009/diff/40001/webrtc/video/rtp_stream_r...
File webrtc/video/rtp_stream_receiver.h (right):

https://codereview.webrtc.org/2565173009/diff/40001/webrtc/video/rtp_stream_r...
webrtc/video/rtp_stream_receiver.h:205: std::map<uint8_t, std::map<std::string,
std::string>> pt_codec_params_;
On 2016/12/19 12:05:23, stefan-webrtc (holmer) wrote:
> Clarify what the mapping is with a comment. "Map from payload type to map from
> ..."

Done.

[stefan-webrtc, 2016-12-19 16:46:41]

lgtm

[philipel, 2016-12-19 16:46:47]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2016-12-19 16:46:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-19 16:56:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 16:56:26]

Try jobs failed on following builders:
  ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/13552)

[philipel, 2016-12-20 11:35:43]

The CQ bit was checked by philipel@webrtc.org

[philipel, 2016-12-20 11:35:44]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2565173009/#ps120001 (title:
"uint16_t -> int16_t")

[commit-bot: I haz the power, 2016-12-20 11:35:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-20 12:15:59]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1482233743709030,
"parent_rev": "ab2ffa3b28b55ef359232723049fb88b2dcd807a", "commit_rev":
"022b54e86a538236b6a3cb97b80dfa1b3e3d5c56"}

[commit-bot: I haz the power, 2016-12-20 12:16:01]

Description was changed from

==========
Wire up H264 fmtp  sprop-parameter-sets with H264SpsPpsTracker.

To avoid making this CL large unittests will be added in a followup CL.

BUG=webrtc:5948

patch from issue 2570073002 at patchset 20001
(http://crrev.com/2570073002#ps20001)
==========

to

==========
Wire up H264 fmtp  sprop-parameter-sets with H264SpsPpsTracker.

To avoid making this CL large unittests will be added in a followup CL.

BUG=webrtc:5948

patch from issue 2570073002 at patchset 20001
(http://crrev.com/2570073002#ps20001)

Review-Url: https://codereview.webrtc.org/2565173009
Cr-Commit-Position: refs/heads/master@{#15710}
Committed:
https://chromium.googlesource.com/external/webrtc/+/022b54e86a538236b6a3cb97b...
==========

[commit-bot: I haz the power, 2016-12-20 12:16:03]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/external/webrtc/+/022b54e86a538236b6a3cb97b...