Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2564673002: Remove extra uses of basictypes.h. (Closed)

Created:
4 years ago by pbos-webrtc
Modified:
4 years ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove extra uses of basictypes.h. None of these files use size_t, int types or any of the macros/types defined in basictypes.h. BUG=webrtc:6853 R=tommi@webrtc.org Committed: https://crrev.com/5493b8a59deb16cf0481e24707a0ed72d19047dc Cr-Commit-Position: refs/heads/master@{#15513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M webrtc/base/common.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/event.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/base/taskparent.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/libjingle/xmpp/jid.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/pc/rtcpmuxfilter.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/typedefs.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
pbos-webrtc
PTAL, let's see if the buildbot agrees with my local build.
4 years ago (2016-12-08 23:18:00 UTC) #1
tommi
lgtm
4 years ago (2016-12-09 12:25:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2564673002/1
4 years ago (2016-12-09 14:50:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 14:54:03 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-09 14:54:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5493b8a59deb16cf0481e24707a0ed72d19047dc
Cr-Commit-Position: refs/heads/master@{#15513}

Powered by Google App Engine
This is Rietveld 408576698