Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2564613002: PRESUBMIT: Add authorized-authors check + AUTHORS e-mails. (Closed)

Created:
4 years ago by kjellander_webrtc
Modified:
4 years ago
Reviewers:
blum1, blum, hta-webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

PRESUBMIT: Add authorized-authors check + AUTHORS e-mails. This check will throw a PRESUBMIT error if the author or organization is not present in the AUTHORS file. E-mail wildcard entries were also added to the organizations in the AUTHORS file. BUG=webrtc:6852 NOTRY=True Committed: https://crrev.com/e5dc62aeb8a724bee0a553f901c051940b6e28b4 Cr-Commit-Position: refs/heads/master@{#15591}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M AUTHORS View 1 chunk +16 lines, -14 lines 1 comment Download
M PRESUBMIT.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
kjellander_webrtc
This should be correct, right? https://codereview.webrtc.org/2564613002/diff/20001/AUTHORS File AUTHORS (right): https://codereview.webrtc.org/2564613002/diff/20001/AUTHORS#newcode55 AUTHORS:55: The Chromium Authors <*@chromium.org> ...
4 years ago (2016-12-08 18:38:33 UTC) #3
hta-webrtc
lgtm but I think you should have a PM review this, since it touches on ...
4 years ago (2016-12-09 10:16:31 UTC) #4
kjellander_webrtc
4 years ago (2016-12-09 10:25:12 UTC) #6
blum
On 2016/12/09 10:25:12, kjellander_webrtc wrote: LGTM
4 years ago (2016-12-13 14:22:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2564613002/20001
4 years ago (2016-12-14 08:12:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-14 08:16:25 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-14 08:16:33 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5dc62aeb8a724bee0a553f901c051940b6e28b4
Cr-Commit-Position: refs/heads/master@{#15591}

Powered by Google App Engine
This is Rietveld 408576698