Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2564423002:
Disable flaky QualityScaler tests for now. (Closed)
|
Created:
4 years ago by kthelgason Modified:
4 years ago Reviewers:
åsapersson CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDisable flaky QualityScaler tests for now.
BUG=webrtc:6799
TBR=sprang@webrtc.org
Committed: https://crrev.com/46711db355f9b017f774c0c80f61c704eb36769a
Cr-Commit-Position: refs/heads/master@{#15573}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 23 (14 generated)
kthelgason@webrtc.org changed reviewers: + asapersson@webrtc.org, sprang@webrtc.org
Disabling these flaky tests for the time being. I will try to figure out a way to make them more deterministic.
The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.webrtc.org/2564423002/diff/1/webrtc/modules/video_coding/u... File webrtc/modules/video_coding/utility/quality_scaler_unittest.cc (right): https://codereview.webrtc.org/2564423002/diff/1/webrtc/modules/video_coding/u... webrtc/modules/video_coding/utility/quality_scaler_unittest.cc:112: DISABLED_TEST(QualityScalerTest, DownscalesAfterContinuousFramedrop) { Could this be TEST_F(QualityScalerTest, DISABLED_DownscalesAfterContinuousFramedrop)
https://codereview.webrtc.org/2564423002/diff/1/webrtc/modules/video_coding/u... File webrtc/modules/video_coding/utility/quality_scaler_unittest.cc (right): https://codereview.webrtc.org/2564423002/diff/1/webrtc/modules/video_coding/u... webrtc/modules/video_coding/utility/quality_scaler_unittest.cc:112: DISABLED_TEST(QualityScalerTest, DownscalesAfterContinuousFramedrop) { On 2016/12/13 13:15:14, åsapersson wrote: > Could this be TEST_F(QualityScalerTest, > DISABLED_DownscalesAfterContinuousFramedrop) Of course, this was just easier to do with find/replace.
lgtm
Description was changed from ========== Disable flaky QualityScaler tests for now. BUG=webrtc:6799 ========== to ========== Disable flaky QualityScaler tests for now. BUG=webrtc:6799 ==========
kthelgason@webrtc.org changed reviewers: - sprang@webrtc.org
The CQ bit was checked by kthelgason@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11373)
Description was changed from ========== Disable flaky QualityScaler tests for now. BUG=webrtc:6799 ========== to ========== Disable flaky QualityScaler tests for now. BUG=webrtc:6799 TBR=sprang@webrtc.org ==========
The CQ bit was checked by kthelgason@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481635768381850, "parent_rev":
"d9a328b1a4a35e954875664dc94e07384776bb34", "commit_rev":
"27e4c9b0e82df2205015f0cd1a589424fa14f276"}
Message was sent while issue was closed.
Description was changed from ========== Disable flaky QualityScaler tests for now. BUG=webrtc:6799 TBR=sprang@webrtc.org ========== to ========== Disable flaky QualityScaler tests for now. BUG=webrtc:6799 TBR=sprang@webrtc.org Review-Url: https://codereview.webrtc.org/2564423002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disable flaky QualityScaler tests for now. BUG=webrtc:6799 TBR=sprang@webrtc.org Review-Url: https://codereview.webrtc.org/2564423002 ========== to ========== Disable flaky QualityScaler tests for now. BUG=webrtc:6799 TBR=sprang@webrtc.org Committed: https://crrev.com/46711db355f9b017f774c0c80f61c704eb36769a Cr-Commit-Position: refs/heads/master@{#15573} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/46711db355f9b017f774c0c80f61c704eb36769a Cr-Commit-Position: refs/heads/master@{#15573} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
