Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2563913003: Disable failing perf test on Android. (Closed)

Created:
4 years ago by kthelgason
Modified:
4 years ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable failing perf test on Android. A decision was recently made to limit downscaling to 320x180 on Android. This causes the perf tests to fail. This test is no longer valid on android, as the failure is expected behaviour. BUG=None NOTRY=true TBR=phoglund@webrtc.org Committed: https://crrev.com/ca87b62edec768315d8a99e2b9acfd713db5c58d Cr-Commit-Position: refs/heads/master@{#15510}

Patch Set 1 #

Patch Set 2 : Disable tests on android for now #

Patch Set 3 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M webrtc/call/call_perf_tests.cc View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
kthelgason
PTAL.
4 years ago (2016-12-09 13:51:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2563913003/40001
4 years ago (2016-12-09 14:13:45 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-09 14:15:22 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/ca87b62edec768315d8a99e2b9acfd713db5c58d Cr-Commit-Position: refs/heads/master@{#15510}
4 years ago (2016-12-09 14:15:25 UTC) #13
phoglund
4 years ago (2016-12-09 14:17:48 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698