Add a gtk3 port of peerconnection_client on Linux

Add a gtk3 port of peerconnection_client on Linux

BUG=668446
Committed: https://crrev.com/ef16e9960f47bf8150eb6782663f0be3f05e0e0a
Cr-Commit-Position: refs/heads/master@{#15569}

[Tom (Use chromium acct), 2016-12-10 00:35:10]

Description was changed from

==========
Add a gtk3 port of peerconnection_client on Linux

BUG=
==========

to

==========
Add a gtk3 port of peerconnection_client on Linux

BUG=668446
==========

[Tom (Use chromium acct), 2016-12-10 00:35:10]

thomasanderson@google.com changed reviewers:
+ tommi@webrtc.org

[Tom (Use chromium acct), 2016-12-10 00:35:19]

tommi@ PTAL

[tommi, 2016-12-10 13:58:06]

tommi@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[tommi, 2016-12-10 13:58:06]

Thanks for the contribution Tom.

+kjellander to take a look at the build files.

In the meantime - have you already gone through the steps as outlined here:
https://webrtc.org/contributing/ ?

[Tom (Use chromium acct), 2016-12-10 18:55:05]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 18:55:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-10 19:14:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 19:14:59]

Dry run: This issue passed the CQ dry run.

[kjellander_webrtc, 2016-12-12 08:17:28]

Looks like a good improvement to me.
Have you tried running the app built with both use_gtk3=true and use_gtk3=false?

[Tom (Use chromium acct), 2016-12-12 18:23:51]

On 2016/12/12 08:17:28, kjellander_webrtc wrote:
> Looks like a good improvement to me.
> Have you tried running the app built with both use_gtk3=true and
use_gtk3=false?

Yes, works with both gtk2 and gtk3, but colors are broken (they were broken
before and after this change, fixing it is out of the scope of this CL).
It looks like the color is encoded as YUV in the frame generator, but we're
rendering using gtk in RGB format.  A change for another day...

On 2016/12/10 13:58:06, tommi (webrtc) wrote:
> Thanks for the contribution Tom.
> 
> +kjellander to take a look at the build files.
> 
> In the meantime - have you already gone through the steps as outlined here:
> https://webrtc.org/contributing/ ?

Yes :)

[kjellander_webrtc, 2016-12-12 18:26:08]

lgtm but you need another OWNER for examples.

[Tom (Use chromium acct), 2016-12-13 01:28:18]

thomasanderson@google.com changed reviewers:
+ glaznev@webrtc.org

[Tom (Use chromium acct), 2016-12-13 01:28:19]

+glaznev@ for //webrtc/examples

[tommi, 2016-12-13 10:40:57]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2016-12-13 10:40:58]

lgtm

[commit-bot: I haz the power, 2016-12-13 10:41:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-13 10:57:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481625657783560, "parent_rev":
"e2ed9a06ead4f50c0f20f154d65e5455fd84479b", "commit_rev":
"aad667b4eb1df5e61d003e2addbb28bcfe11ff5c"}

[commit-bot: I haz the power, 2016-12-13 10:57:46]

Description was changed from

==========
Add a gtk3 port of peerconnection_client on Linux

BUG=668446
==========

to

==========
Add a gtk3 port of peerconnection_client on Linux

BUG=668446

Review-Url: https://codereview.webrtc.org/2563203002
==========

[commit-bot: I haz the power, 2016-12-13 10:57:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-13 10:57:54]

Description was changed from

==========
Add a gtk3 port of peerconnection_client on Linux

BUG=668446

Review-Url: https://codereview.webrtc.org/2563203002
==========

to

==========
Add a gtk3 port of peerconnection_client on Linux

BUG=668446

Committed: https://crrev.com/ef16e9960f47bf8150eb6782663f0be3f05e0e0a
Cr-Commit-Position: refs/heads/master@{#15569}
==========

[commit-bot: I haz the power, 2016-12-13 10:57:55]

Patchset 1 (id:??) landed as
https://crrev.com/ef16e9960f47bf8150eb6782663f0be3f05e0e0a
Cr-Commit-Position: refs/heads/master@{#15569}