Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2562963002: Revert of Bump up scaling limit for MediaCodec. (Closed)

Created:
4 years ago by kthelgason
Modified:
4 years ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Bump up scaling limit for MediaCodec. (patchset #3 id:40001 of https://codereview.webrtc.org/2566533002/ ) Reason for revert: Failed on the perf tests. Original issue's description: > Bump up scaling limit for MediaCodec. > > Wait until MediaCodec is better tested at these low > resolutions, and until some fallback mechanism is in place > before lowering this threshold. > > BUG=webrtc:6837 > > Committed: https://crrev.com/3e9b1330467edf6b5af609b375c15efb9e6b4933 > Cr-Commit-Position: refs/heads/master@{#15498} TBR=magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6837 Committed: https://crrev.com/1cd0a0ab43846072b1e2f37c953ecd770feb5963 Cr-Commit-Position: refs/heads/master@{#15500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M webrtc/video/vie_encoder.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kthelgason
Created Revert of Bump up scaling limit for MediaCodec.
4 years ago (2016-12-09 10:30:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2562963002/1
4 years ago (2016-12-09 10:30:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 10:30:49 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1cd0a0ab43846072b1e2f37c953ecd770feb5963 Cr-Commit-Position: refs/heads/master@{#15500}
4 years ago (2016-12-09 10:30:56 UTC) #8
kthelgason
4 years ago (2016-12-09 10:37:18 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2567613002/ by kthelgason@webrtc.org.

The reason for reverting is: Fixed perf tests..

Powered by Google App Engine
This is Rietveld 408576698