Chromium Code Reviews

Issue 2562333003: Revert of Support external audio mixer. (Closed)

Created:
4 years ago by GeorgeZ
Modified:
4 years ago
Reviewers:
the sun, emircan, aleloi, Taylor Brandstetter
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, tlegrand-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Support external audio mixer. (patchset #5 id:140001 of https://codereview.webrtc.org/2539213003/ ) Reason for revert: A interface change broke some downstream code in google3. Original issue's description: > Support external audio mixer in webrtc. > > An external audio mixer will be passed from PeerConnectionFactory to > AudioTransportProxy. > > BUG=webrtc:6457 > > Committed: https://crrev.com/f6bcac59e88c3be5ffd73bbb1098f2d82ee316a1 > Cr-Commit-Position: refs/heads/master@{#15556} TBR=solenberg@webrtc.org,aleloi@webrtc.org,deadbeef@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6457 Committed: https://crrev.com/39ce11f7f65d773c09e540774900e206b5be06fc Cr-Commit-Position: refs/heads/master@{#15557}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+65 lines, -121 lines)
M webrtc/api/peerconnectionfactory.h View 2 chunks +1 line, -5 lines 0 comments
M webrtc/api/peerconnectionfactory.cc View 5 chunks +27 lines, -36 lines 0 comments
M webrtc/api/peerconnectioninterface.h View 2 chunks +0 lines, -15 lines 0 comments
M webrtc/audio/audio_receive_stream.cc View 1 chunk +1 line, -1 line 0 comments
M webrtc/media/base/fakemediaengine.h View 2 chunks +4 lines, -5 lines 0 comments
M webrtc/media/base/mediaengine.h View 2 chunks +5 lines, -6 lines 0 comments
M webrtc/media/engine/nullwebrtcvideoengine_unittest.cc View 1 chunk +1 line, -3 lines 0 comments
M webrtc/media/engine/webrtcmediaengine.h View 2 chunks +1 line, -3 lines 0 comments
M webrtc/media/engine/webrtcmediaengine.cc View 4 chunks +11 lines, -20 lines 0 comments
M webrtc/media/engine/webrtcmediaengine_unittest.cc View 1 chunk +1 line, -2 lines 0 comments
M webrtc/media/engine/webrtcvoiceengine.h View 2 chunks +1 line, -4 lines 0 comments
M webrtc/media/engine/webrtcvoiceengine.cc View 2 chunks +5 lines, -14 lines 0 comments
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments

Messages

Total messages: 16 (7 generated)
GeorgeZ
Created Revert of Support external audio mixer.
4 years ago (2016-12-13 01:03:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2562333003/1
4 years ago (2016-12-13 01:03:23 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-13 01:03:24 UTC) #5
GeorgeZ
4 years ago (2016-12-13 01:04:30 UTC) #7
emircan
On 2016/12/13 01:04:30, GeorgeZ wrote: lgtm for revert
4 years ago (2016-12-13 01:04:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2562333003/1
4 years ago (2016-12-13 01:06:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 01:06:55 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/39ce11f7f65d773c09e540774900e206b5be06fc Cr-Commit-Position: refs/heads/master@{#15557}
4 years ago (2016-12-13 01:07:05 UTC) #15
the sun
4 years ago (2016-12-13 07:58:52 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine