Implement parsing/serialization of a=bundle-only.

Implement parsing/serialization of a=bundle-only.

This CL doesn't start *using* a=bundle-only; it just adds support for
parsing it. We need to do this first, because otherwise old versions of
WebRTC will interpret a zero port value as a rejected m= section.

BUG=webrtc:4674
Committed: https://crrev.com/25ed435afee393ef94cb0cd357ff594407b0453d
Cr-Commit-Position: refs/heads/master@{#15558}

[Taylor Brandstetter, 2016-12-10 20:57:12]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2016-12-10 20:57:13]

PTAL Peter. When I was looking at the gaps between our BUNDLE implementation and
the spec, I realized we should at least start supporting parsing of bundle-only,
so we can start using it some time in 2017.

[pthatcher1, 2016-12-12 23:38:30]

lgtm

https://codereview.webrtc.org/2562183002/diff/1/webrtc/api/webrtcsdp.cc
File webrtc/api/webrtcsdp.cc (right):

https://codereview.webrtc.org/2562183002/diff/1/webrtc/api/webrtcsdp.cc#newco...
webrtc/api/webrtcsdp.cc:283: SdpParseError* error);
This could really use one out parameter that is a struct instead of having 6-7.

[Taylor Brandstetter, 2016-12-13 02:13:59]

https://codereview.webrtc.org/2562183002/diff/1/webrtc/api/webrtcsdp.cc
File webrtc/api/webrtcsdp.cc (right):

https://codereview.webrtc.org/2562183002/diff/1/webrtc/api/webrtcsdp.cc#newco...
webrtc/api/webrtcsdp.cc:283: SdpParseError* error);
On 2016/12/12 23:38:29, pthatcher1 wrote:
> This could really use one out parameter that is a struct instead of having
6-7.

Agreed, I don't know why we can't just use a ContentInfo. I guess because you're
not able to create a ContentInfo then add it to a SessionDescription, you need
to call "AddContent(list of params)". But that doesn't make sense in the first
place. I'll clean it up eventually.

[Taylor Brandstetter, 2016-12-13 02:14:04]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-12-13 02:14:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-13 02:37:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481595244179660, "parent_rev":
"eb3453a21670d9d916149cd715bd487959d7971d", "commit_rev":
"50024f6a270210f9cf4a8cb4b05fb998b52806a1"}

[commit-bot: I haz the power, 2016-12-13 02:37:39]

Description was changed from

==========
Implement parsing/serialization of a=bundle-only.

This CL doesn't start *using* a=bundle-only; it just adds support for
parsing it. We need to do this first, because otherwise old versions of
WebRTC will interpret a zero port value as a rejected m= section.

BUG=webrtc:4674
==========

to

==========
Implement parsing/serialization of a=bundle-only.

This CL doesn't start *using* a=bundle-only; it just adds support for
parsing it. We need to do this first, because otherwise old versions of
WebRTC will interpret a zero port value as a rejected m= section.

BUG=webrtc:4674

Review-Url: https://codereview.webrtc.org/2562183002
==========

[commit-bot: I haz the power, 2016-12-13 02:37:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-13 02:37:49]

Description was changed from

==========
Implement parsing/serialization of a=bundle-only.

This CL doesn't start *using* a=bundle-only; it just adds support for
parsing it. We need to do this first, because otherwise old versions of
WebRTC will interpret a zero port value as a rejected m= section.

BUG=webrtc:4674

Review-Url: https://codereview.webrtc.org/2562183002
==========

to

==========
Implement parsing/serialization of a=bundle-only.

This CL doesn't start *using* a=bundle-only; it just adds support for
parsing it. We need to do this first, because otherwise old versions of
WebRTC will interpret a zero port value as a rejected m= section.

BUG=webrtc:4674

Committed: https://crrev.com/25ed435afee393ef94cb0cd357ff594407b0453d
Cr-Commit-Position: refs/heads/master@{#15558}
==========

[commit-bot: I haz the power, 2016-12-13 02:37:49]

Patchset 1 (id:??) landed as
https://crrev.com/25ed435afee393ef94cb0cd357ff594407b0453d
Cr-Commit-Position: refs/heads/master@{#15558}

[pthatcher1, 2017-01-03 17:31:01]

https://codereview.webrtc.org/2562183002/diff/1/webrtc/api/webrtcsdp.cc
File webrtc/api/webrtcsdp.cc (right):

https://codereview.webrtc.org/2562183002/diff/1/webrtc/api/webrtcsdp.cc#newco...
webrtc/api/webrtcsdp.cc:2374: }
It looks like we need to remove this block (or comment it out) until Firefox
fixes their SDP:

https://bugzilla.mozilla.org/show_bug.cgi?id=1325991

https://codereview.webrtc.org/2562183002/diff/1/webrtc/api/webrtcsdp_unittest.cc
File webrtc/api/webrtcsdp_unittest.cc (right):

https://codereview.webrtc.org/2562183002/diff/1/webrtc/api/webrtcsdp_unittest...
webrtc/api/webrtcsdp_unittest.cc:391: "a=ssrc:3 label:video_track_id_1\r\n";
We should probably add a test for broken SDP from Firefox, like this SDP:

https://bugzilla.mozilla.org/show_bug.cgi?id=1325991