Added functionality for simulating custom orders of the stream API calls in audioproc_f

During AEC development, it is handy to be able to simulate different
orders of the ProcessStream and ProcessReverseStream API calls.

This CL adds the ability to specify that call order in a file.

BUG=webrtc:6018
Committed: https://crrev.com/5ad5de37160c4a650ed388a7c82533919937b5e1
Cr-Commit-Position: refs/heads/master@{#15503}

[peah-webrtc, 2016-12-09 10:00:47]

Description was changed from

==========
Added functionality for custom call order

BUG=
==========

to

==========
During AEC development, it is handy to be able to simulate different
orders of the ProcessStream and ProcessReverseStream API calls.

This CL adds the ability to specify that call order in a file.

BUG=webrtc:6018
==========

[peah-webrtc, 2016-12-09 10:01:45]

peah@webrtc.org changed reviewers:
+ aleloi@webrtc.org, henrik.lundin@webrtc.org, ivoc@webrtc.org

[peah-webrtc, 2016-12-09 10:01:46]

PTAL
Thanks!

[aleloi, 2016-12-09 10:25:44]

LGTM with question.

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/test/audioproc_float.cc (right):

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/audioproc_float.cc:264:
SetSettingIfSpecified(FLAGS_custom_call_order_file,
Suggestion: move up to 258.

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/test/wav_based_simulator.cc (left):

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/wav_based_simulator.cc:25:
WavBasedSimulator::GetDefaultEventChain() const {
Why is GetDefaultEventChain not const now?

[ivoc, 2016-12-09 10:28:20]

lgtm with one comment.

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/test/wav_based_simulator.cc (right):

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/wav_based_simulator.cc:34: size_t num_read
= fread(&c, sizeof(char), 1, stream);
I think this is defined in <stdio.h>, shouldn't that be included here? I'm also
not sure what <string.h> and <iostream> are used for in this file.

[hlundin-webrtc, 2016-12-09 10:40:18]

LGTM with the usual complaints about over-nice error handling.

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/test/wav_based_simulator.cc (left):

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/wav_based_simulator.cc:25:
WavBasedSimulator::GetDefaultEventChain() const {
On 2016/12/09 10:25:44, aleloi wrote:
> Why is GetDefaultEventChain not const now?

It was made static in the header file.

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/test/wav_based_simulator.cc (right):

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/wav_based_simulator.cc:27: if (!stream) {
This is test/tools code. Crashing and burning rather than giving the user
something they didn't ask for is imo better.

RTC_CHECK(stream) << "Boy, that escalated quickly...";

instead of the if-clause.

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/wav_based_simulator.cc:46: std::cout <<
"Incorrect custom call order file, reverting to using the "
FATAL() << "What kind of input is this?!";

[peah-webrtc, 2016-12-09 10:50:00]

Thanks for the review!

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/test/audioproc_float.cc (right):

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/audioproc_float.cc:264:
SetSettingIfSpecified(FLAGS_custom_call_order_file,
On 2016/12/09 10:25:44, aleloi wrote:
> Suggestion: move up to 258.

Done.

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/test/wav_based_simulator.cc (left):

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/wav_based_simulator.cc:25:
WavBasedSimulator::GetDefaultEventChain() const {
On 2016/12/09 10:25:44, aleloi wrote:
> Why is GetDefaultEventChain not const now?

I made it static which caused it not possible to make it const.

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/wav_based_simulator.cc:25:
WavBasedSimulator::GetDefaultEventChain() const {
On 2016/12/09 10:40:17, hlundin-webrtc wrote:
> On 2016/12/09 10:25:44, aleloi wrote:
> > Why is GetDefaultEventChain not const now?
> 
> It was made static in the header file.

Acknowledged.

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/test/wav_based_simulator.cc (right):

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/wav_based_simulator.cc:27: if (!stream) {
On 2016/12/09 10:40:17, hlundin-webrtc wrote:
> This is test/tools code. Crashing and burning rather than giving the user
> something they didn't ask for is imo better.
> 
> RTC_CHECK(stream) << "Boy, that escalated quickly...";
> 
> instead of the if-clause.

Done.

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/wav_based_simulator.cc:34: size_t num_read
= fread(&c, sizeof(char), 1, stream);
On 2016/12/09 10:28:20, ivoc wrote:
> I think this is defined in <stdio.h>, shouldn't that be included here? I'm
also
> not sure what <string.h> and <iostream> are used for in this file.

Good point! I removed the inclusion of <string.h> and added inclusion of
<stdio.h>.
<iostream> is needed for cout.

https://codereview.webrtc.org/2561843003/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/wav_based_simulator.cc:46: std::cout <<
"Incorrect custom call order file, reverting to using the "
On 2016/12/09 10:40:17, hlundin-webrtc wrote:
> FATAL() << "What kind of input is this?!";

Done.

[peah-webrtc, 2016-12-09 10:50:07]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2016-12-09 10:50:07]

The patchset sent to the CQ was uploaded after l-g-t-m from ivoc@webrtc.org,
henrik.lundin@webrtc.org, aleloi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2561843003/#ps20001 (title:
"Changes in response to reviewer comments")

[commit-bot: I haz the power, 2016-12-09 10:50:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-09 11:18:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481280607460860,
"parent_rev": "b0781adba79d14a64881e88447eedeadce7e7e30", "commit_rev":
"d6ed5acc46ae936c416cf88e02753a8d6fa60e91"}

[commit-bot: I haz the power, 2016-12-09 11:18:26]

Description was changed from

==========
During AEC development, it is handy to be able to simulate different
orders of the ProcessStream and ProcessReverseStream API calls.

This CL adds the ability to specify that call order in a file.

BUG=webrtc:6018
==========

to

==========
During AEC development, it is handy to be able to simulate different
orders of the ProcessStream and ProcessReverseStream API calls.

This CL adds the ability to specify that call order in a file.

BUG=webrtc:6018

Review-Url: https://codereview.webrtc.org/2561843003
==========

[commit-bot: I haz the power, 2016-12-09 11:18:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-09 11:18:35]

Description was changed from

==========
During AEC development, it is handy to be able to simulate different
orders of the ProcessStream and ProcessReverseStream API calls.

This CL adds the ability to specify that call order in a file.

BUG=webrtc:6018

Review-Url: https://codereview.webrtc.org/2561843003
==========

to

==========
During AEC development, it is handy to be able to simulate different
orders of the ProcessStream and ProcessReverseStream API calls.

This CL adds the ability to specify that call order in a file.

BUG=webrtc:6018

Committed: https://crrev.com/5ad5de37160c4a650ed388a7c82533919937b5e1
Cr-Commit-Position: refs/heads/master@{#15503}
==========

[commit-bot: I haz the power, 2016-12-09 11:18:37]

Patchset 2 (id:??) landed as
https://crrev.com/5ad5de37160c4a650ed388a7c82533919937b5e1
Cr-Commit-Position: refs/heads/master@{#15503}