Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 2561123002: Move FlexfecReceiveStream from api/call/ to call/. (Closed)

Created:
4 years ago by brandtr
Modified:
4 years ago
Reviewers:
the sun, mflodman
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move FlexfecReceiveStream from api/call/ to call/. Also rename internal::FlexfecReceiveStream to FlexfecReceiveStreamImpl. BUG=webrtc:6849 Review-Url: https://codereview.webrtc.org/2561123002 Cr-Commit-Position: refs/heads/master@{#15666} Committed: https://chromium.googlesource.com/external/webrtc/+/7250b398a19bddc4c6f6dc75ac993f22cdca91b0

Patch Set 1 #

Patch Set 2 : Fix BUILD file. #

Total comments: 4

Patch Set 3 : solenberg comments 1. #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -299 lines) Patch
M webrtc/api/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/api/call/flexfec_receive_stream.h View 1 chunk +0 lines, -86 lines 0 comments Download
M webrtc/call/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/call/call.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/call.cc View 5 chunks +19 lines, -18 lines 0 comments Download
M webrtc/call/flexfec_receive_stream.h View 1 chunk +52 lines, -23 lines 0 comments Download
D webrtc/call/flexfec_receive_stream.cc View 1 chunk +0 lines, -134 lines 0 comments Download
A + webrtc/call/flexfec_receive_stream_impl.h View 1 2 2 chunks +9 lines, -13 lines 0 comments Download
A + webrtc/call/flexfec_receive_stream_impl.cc View 3 chunks +12 lines, -15 lines 0 comments Download
M webrtc/call/flexfec_receive_stream_unittest.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
brandtr
Please have a look :)
4 years ago (2016-12-09 08:37:44 UTC) #2
the sun
lgtm https://codereview.webrtc.org/2561123002/diff/20001/webrtc/call/flexfec_receive_stream_impl.h File webrtc/call/flexfec_receive_stream_impl.h (right): https://codereview.webrtc.org/2561123002/diff/20001/webrtc/call/flexfec_receive_stream_impl.h#newcode24 webrtc/call/flexfec_receive_stream_impl.h:24: class FlexfecReceiveStreamImpl : public FlexfecReceiveStream { Note: after ...
4 years ago (2016-12-09 08:59:38 UTC) #3
brandtr
https://codereview.webrtc.org/2561123002/diff/20001/webrtc/call/flexfec_receive_stream_impl.h File webrtc/call/flexfec_receive_stream_impl.h (right): https://codereview.webrtc.org/2561123002/diff/20001/webrtc/call/flexfec_receive_stream_impl.h#newcode24 webrtc/call/flexfec_receive_stream_impl.h:24: class FlexfecReceiveStreamImpl : public FlexfecReceiveStream { On 2016/12/09 08:59:38, ...
4 years ago (2016-12-09 09:19:23 UTC) #4
brandtr
Rebase.
4 years ago (2016-12-12 09:24:00 UTC) #5
brandtr
Rebase.
4 years ago (2016-12-19 08:56:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2561123002/80001
4 years ago (2016-12-19 08:58:03 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-19 09:13:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/7250b398a19bddc4c6f6dc75a...

Powered by Google App Engine
This is Rietveld 408576698