Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 2559973002: RTCInboundRTPStreamStats.packetsLost set by RTCStatsCollector. (Closed)

Created:
4 years ago by hbos
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

RTCInboundRTPStreamStats.packetsLost set by RTCStatsCollector. Spec: https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-packetslost BUG=chromium:657855 Committed: https://crrev.com/02cd4d6dfc74da8c2275831e0ae3807cb58f0c76 Cr-Commit-Position: refs/heads/master@{#15507}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M webrtc/api/rtcstats_integrationtest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/rtcstatscollector.cc View 1 chunk +2 lines, -0 lines 1 comment Download
M webrtc/api/rtcstatscollector_unittest.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M webrtc/api/stats/rtcstats_objects.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
hbos
Please take a look, deadbeef && hta. https://codereview.webrtc.org/2559973002/diff/1/webrtc/api/rtcstatscollector.cc File webrtc/api/rtcstatscollector.cc (right): https://codereview.webrtc.org/2559973002/diff/1/webrtc/api/rtcstatscollector.cc#newcode154 webrtc/api/rtcstatscollector.cc:154: static_cast<uint32_t>(media_receiver_info.packets_lost); This ...
4 years ago (2016-12-08 15:16:30 UTC) #4
Taylor Brandstetter
lgtm
4 years ago (2016-12-08 22:02:51 UTC) #7
hta-webrtc
lgtm
4 years ago (2016-12-09 09:49:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2559973002/1
4 years ago (2016-12-09 12:08:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 12:19:48 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-09 12:19:53 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02cd4d6dfc74da8c2275831e0ae3807cb58f0c76
Cr-Commit-Position: refs/heads/master@{#15507}

Powered by Google App Engine
This is Rietveld 408576698