Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2558813003: Refactor webrtc/modules/audio_processing for GN check (Closed)

Created:
4 years ago by ehmaldonado_webrtc
Modified:
4 years ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), kwiberg-webrtc, Andrew MacDonald, hlundin-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Refactor webrtc/modules/audio_processing for GN check This moves some GN check configurations out of .gn to individual targets. The now checked target is: "//webrtc/modules/audio_processing/*", BUG=webrtc:6828 NOTRY=True R=kjellander@webrtc.org Committed: https://crrev.com/64c4a7ecfc86307136e3dd07ac46462b56d60fda Cr-Commit-Position: refs/heads/master@{#15475}

Patch Set 1 #

Patch Set 2 : Some changes. #

Patch Set 3 : Fixed android errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -37 lines) Patch
M .gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M PRESUBMIT.py View 2 chunks +0 lines, -37 lines 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 1 2 12 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ehmaldonado_webrtc
4 years ago (2016-12-07 15:40:46 UTC) #1
ehmaldonado_webrtc
PTAL
4 years ago (2016-12-07 17:26:30 UTC) #2
ehmaldonado_webrtc
It works now :) PTAL
4 years ago (2016-12-07 19:24:56 UTC) #3
kjellander_webrtc
lgtm
4 years ago (2016-12-08 09:09:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2558813003/40001
4 years ago (2016-12-08 12:06:47 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-08 12:10:04 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-08 12:10:14 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/64c4a7ecfc86307136e3dd07ac46462b56d60fda
Cr-Commit-Position: refs/heads/master@{#15475}

Powered by Google App Engine
This is Rietveld 408576698