Refactor webrtc/modules/audio_processing for GN check

PRESUBMIT.py

 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import json
 import os
@@ skipping 210 matching lines @@
     if input_api.is_committing:
       # TODO(kjellander): Change back to PresubmitError below when we're
       # confident with the lint settings.
       res_type = output_api.PresubmitPromptWarning
     else:
       res_type = output_api.PresubmitPromptWarning
     result = [res_type('Changelist failed cpplint.py check.')]
 
   return result
 
-def _CheckNoRtcBaseDeps(input_api, gn_files, output_api):
-  pattern = input_api.re.compile(r'base:rtc_base\s*"')
-  violating_files = []
-  for f in gn_files:
-    gn_exceptions = (
-        os.path.join('audio_device', 'BUILD.gn'),
-        os.path.join('base_tests', 'BUILD.gn'),
-        os.path.join('desktop_capture', 'BUILD.gn'),
-        os.path.join('p2p', 'BUILD.gn'),
-        os.path.join('sdk', 'BUILD.gn'),
-        os.path.join('webrtc_test_common', 'BUILD.gn'),
-        os.path.join('webrtc_tests', 'BUILD.gn'),
-
-        # TODO(ehmaldonado): Clean up references to rtc_base in these files.
-        # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3806
-        os.path.join('webrtc', 'BUILD.gn'),
-        os.path.join('xmllite', 'BUILD.gn'),
-        os.path.join('xmpp', 'BUILD.gn'),
-        os.path.join('modules', 'BUILD.gn'),
-        os.path.join('audio_device', 'BUILD.gn'),
-        os.path.join('pc', 'BUILD.gn'),
-    )
-    if f.LocalPath().endswith(gn_exceptions):
-      continue
-    contents = input_api.ReadFile(f)
-    if pattern.search(contents):
-      violating_files.append(f)
-  if violating_files:
-    return [output_api.PresubmitError(
-        'Depending on rtc_base is not allowed. Change your dependency to '
-        'rtc_base_approved and possibly sanitize and move the desired source '
-        'file(s) to rtc_base_approved.\nChanged GN files:',
-        items=violating_files)]
-  return []
-
-
 def _CheckNoSourcesAbove(input_api, gn_files, output_api):
   # Disallow referencing source files with paths above the GN file location.
   source_pattern = input_api.re.compile(r' +sources \+?= \[(.*?)\]',
                                         re.MULTILINE | re.DOTALL)
   file_pattern = input_api.re.compile(r'"((\.\./.*?)|(//.*?))"')
   violating_gn_files = set()
   violating_source_entries = []
   for gn_file in gn_files:
     contents = input_api.ReadFile(gn_file)
     for source_block_match in source_pattern.finditer(contents):
@@ skipping 48 matching lines @@
   source_file_filter = lambda x: input_api.FilterSourceFile(
       x, white_list=(r'.+\.(gn|gni)$',))
 
   gn_files = []
   for f in input_api.AffectedSourceFiles(source_file_filter):
     if f.LocalPath().startswith('webrtc'):
       gn_files.append(f)
 
   result = []
   if gn_files:
-    result.extend(_CheckNoRtcBaseDeps(input_api, gn_files, output_api))
     result.extend(_CheckNoSourcesAbove(input_api, gn_files, output_api))
     result.extend(_CheckNoMixingCAndCCSources(input_api, gn_files, output_api))
   return result
 
 def _CheckUnwantedDependencies(input_api, output_api):
   """Runs checkdeps on #include statements added in this
   change. Breaking - rules is an error, breaking ! rules is a
   warning.
   """
   # Copied from Chromium's src/PRESUBMIT.py.
@@ skipping 211 matching lines @@
       input_api, output_api))
   results.extend(input_api.canned_checks.CheckChangeHasDescription(
       input_api, output_api))
   results.extend(_CheckChangeHasBugField(input_api, output_api))
   results.extend(input_api.canned_checks.CheckChangeHasTestField(
       input_api, output_api))
   results.extend(input_api.canned_checks.CheckTreeIsOpen(
       input_api, output_api,
       json_url='http://webrtc-status.appspot.com/current?format=json'))
   return results