Translate isolated-script-test-output to dump_json_test_results in gtest-parallel-wrapper.py

Translate isolated-script-test-output to dump_json_test_results in gtest-parallel-wrapper.py

BUG=chromium:325726
R=kjellander@webrtc.org
NOTRY=True

Committed: https://crrev.com/dd33e63378a5ccb134bb52f935f67cd58c904e98
Cr-Commit-Position: refs/heads/master@{#15463}

[kjellander_webrtc, 2016-12-07 12:36:09]

We're getting close to flakiness reporting!

https://codereview.webrtc.org/2558783002/diff/1/third_party/gtest-parallel/gt...
File third_party/gtest-parallel/gtest-parallel-wrapper.py (right):

https://codereview.webrtc.org/2558783002/diff/1/third_party/gtest-parallel/gt...
third_party/gtest-parallel/gtest-parallel-wrapper.py:11: import os
I think it'd be nice with a short module documentation up here.

https://codereview.webrtc.org/2558783002/diff/1/third_party/gtest-parallel/gt...
third_party/gtest-parallel/gtest-parallel-wrapper.py:36: if
sys.argv[i].startswith('--isolated-script-test-output'):
Can you use argparse and add --isolated-script-test-output as a "supported" flag
for gtest-parallel-wrapper.py instead? Then we can avoid this manual parsing.

It will also break if the path following --isolated-script-test-output is passed
space-delimited instead of using '=' as a separator.

[ehmaldonado_webrtc, 2016-12-07 14:14:58]

On 2016/12/07 12:36:09, kjellander_webrtc wrote:
> We're getting close to flakiness reporting!
> 
>
https://codereview.webrtc.org/2558783002/diff/1/third_party/gtest-parallel/gt...
> File third_party/gtest-parallel/gtest-parallel-wrapper.py (right):
> 
>
https://codereview.webrtc.org/2558783002/diff/1/third_party/gtest-parallel/gt...
> third_party/gtest-parallel/gtest-parallel-wrapper.py:11: import os
> I think it'd be nice with a short module documentation up here.
> 
>
https://codereview.webrtc.org/2558783002/diff/1/third_party/gtest-parallel/gt...
> third_party/gtest-parallel/gtest-parallel-wrapper.py:36: if
> sys.argv[i].startswith('--isolated-script-test-output'):
> Can you use argparse and add --isolated-script-test-output as a "supported"
flag
> for gtest-parallel-wrapper.py instead? Then we can avoid this manual parsing.
> 
> It will also break if the path following --isolated-script-test-output is
passed
> space-delimited instead of using '=' as a separator.

PTAL.
I ignored '--', and just pass the unprocessed arguments as test arguments to
gtest-parallel, because optparse stops processing after '--'.
Also added some module documentation.

[ehmaldonado_webrtc, 2016-12-07 14:16:54]

On 2016/12/07 14:14:58, ehmaldonado_webrtc wrote:
> On 2016/12/07 12:36:09, kjellander_webrtc wrote:
> > We're getting close to flakiness reporting!
> > 
> >
>
https://codereview.webrtc.org/2558783002/diff/1/third_party/gtest-parallel/gt...
> > File third_party/gtest-parallel/gtest-parallel-wrapper.py (right):
> > 
> >
>
https://codereview.webrtc.org/2558783002/diff/1/third_party/gtest-parallel/gt...
> > third_party/gtest-parallel/gtest-parallel-wrapper.py:11: import os
> > I think it'd be nice with a short module documentation up here.
> > 
> >
>
https://codereview.webrtc.org/2558783002/diff/1/third_party/gtest-parallel/gt...
> > third_party/gtest-parallel/gtest-parallel-wrapper.py:36: if
> > sys.argv[i].startswith('--isolated-script-test-output'):
> > Can you use argparse and add --isolated-script-test-output as a "supported"
> flag
> > for gtest-parallel-wrapper.py instead? Then we can avoid this manual
parsing.
> > 
> > It will also break if the path following --isolated-script-test-output is
> passed
> > space-delimited instead of using '=' as a separator.
> 
> PTAL.
> I ignored '--', and just pass the unprocessed arguments as test arguments to
> gtest-parallel, because optparse stops processing after '--'.
> Also added some module documentation.

(i.e. 
./third_party/gtest-parallel/gtest-parallel-wrapper.py
out/gn/audio_decoder_unittests --isolated-script-test-output=some_dir --
--extra_args
is converted into
/usr/bin/python
/usr/local/google/home/ehmaldonado/webrtc/src/third_party/gtest-parallel/gtest-parallel
out/gn/audio_decoder_unittests --shard_count 1 --shard_index 0
--dump_json_test_results some_dir -- --extra_args
)

[kjellander_webrtc, 2016-12-07 15:12:54]

lgtm but I'd add your concrete example to the documentation as well.

[ehmaldonado_webrtc, 2016-12-07 15:57:27]

The CQ bit was checked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2016-12-07 15:57:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2558783002/#ps40001 (title:
"Made sure it works.")

[commit-bot: I haz the power, 2016-12-07 15:57:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-07 16:06:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 16:06:01]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11157)

[ehmaldonado_webrtc, 2016-12-07 16:20:16]

ehmaldonado@webrtc.org changed reviewers:
+ pbos@webrtc.org

[ehmaldonado_webrtc, 2016-12-07 16:20:17]

Maybe we could add kjellander as an OWNER for gtest-parallel-wrapper.py?

pbos: can you review, please?

[pbos-webrtc, 2016-12-07 16:26:35]

On 2016/12/07 16:20:17, ehmaldonado_webrtc wrote:
> Maybe we could add kjellander as an OWNER for gtest-parallel-wrapper.py?
> 
> pbos: can you review, please?

I think you should own it, https://codereview.webrtc.org/2558093002.

[ehmaldonado_webrtc, 2016-12-07 16:50:21]

Description was changed from

==========
Translate isolated-script-test-output to dump_json_test_results in
gtest-parallel-wrapper.py

BUG=chromium:325726
R=kjellander@webrtc.org
==========

to

==========
Translate isolated-script-test-output to dump_json_test_results in
gtest-parallel-wrapper.py

BUG=chromium:325726
R=kjellander@webrtc.org
NOTRY=True
==========

[ehmaldonado_webrtc, 2016-12-07 16:50:28]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2016-12-07 16:50:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-07 16:52:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481129428843050,
"parent_rev": "c0cd74f133e8081b8d763f2bbbf2689b38b6669d", "commit_rev":
"a410216cb8021ce481d0a777f674322c109dc829"}

[commit-bot: I haz the power, 2016-12-07 16:52:19]

Description was changed from

==========
Translate isolated-script-test-output to dump_json_test_results in
gtest-parallel-wrapper.py

BUG=chromium:325726
R=kjellander@webrtc.org
NOTRY=True
==========

to

==========
Translate isolated-script-test-output to dump_json_test_results in
gtest-parallel-wrapper.py

BUG=chromium:325726
R=kjellander@webrtc.org
NOTRY=True
==========

[commit-bot: I haz the power, 2016-12-07 16:52:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-07 16:52:24]

Description was changed from

==========
Translate isolated-script-test-output to dump_json_test_results in
gtest-parallel-wrapper.py

BUG=chromium:325726
R=kjellander@webrtc.org
NOTRY=True
==========

to

==========
Translate isolated-script-test-output to dump_json_test_results in
gtest-parallel-wrapper.py

BUG=chromium:325726
R=kjellander@webrtc.org
NOTRY=True

Committed: https://crrev.com/dd33e63378a5ccb134bb52f935f67cd58c904e98
Cr-Commit-Position: refs/heads/master@{#15463}
==========

[commit-bot: I haz the power, 2016-12-07 16:52:25]

Patchset 3 (id:??) landed as
https://crrev.com/dd33e63378a5ccb134bb52f935f67cd58c904e98
Cr-Commit-Position: refs/heads/master@{#15463}