Translate isolated-script-test-output to dump_json_test_results in gtest-parallel-wrapper.py

third_party/gtest-parallel/gtest-parallel-wrapper.py

 #!/usr/bin/env python
 
 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import os

[kjellander_webrtc, 2016/12/07 12:36:09]

I think it'd be nice with a short module documentation up here.

 import subprocess
 import sys
 
 # GTEST_SHARD_INDEX and GTEST_TOTAL_SHARDS must be removed from the environment
 # otherwise it will be picked up by the binary, causing a bug where only tests
 # in the firsh shard are executed.
 test_env = os.environ.copy()
 gtest_shard_index = test_env.pop('GTEST_SHARD_INDEX', '0')
 gtest_total_shards = test_env.pop('GTEST_TOTAL_SHARDS', '1')
 
 gtest_parallel_path = os.path.dirname(os.path.abspath(__file__))
 gtest_parallel_path = os.path.join(gtest_parallel_path, 'gtest-parallel')
 
+gtest_args = [
+    '--shard_count',
+    gtest_total_shards,
+    '--shard_index',
+    gtest_shard_index,
+]
+
+# --isolated-script-test-output is used to upload results to the flakiness
+# dashboard. This translation is made because gtest-parallel expects the flag to
+# be called --dump_json_test_results instead.
+for i in range(len(sys.argv)):
+  if sys.argv[i].startswith('--isolated-script-test-output'):

[kjellander_webrtc, 2016/12/07 12:36:09]

Can you use argparse and add --isolated-script-test-output as a "supported" flag
for gtest-parallel-wrapper.py instead? Then we can avoid this manual parsing.

It will also break if the path following --isolated-script-test-output is passed
space-delimited instead of using '=' as a separator.

+    gtest_args += [
+        '--dump_json_test_results',
+        sys.argv[i][sys.argv[i].find('=')+1:]
+    ]
+    del sys.argv[i]
+    break
+
 command = [
     sys.executable,
     gtest_parallel_path,
-    '--shard_count',
-    gtest_total_shards,
-    '--shard_index',
-    gtest_shard_index,
-] + sys.argv[1:]
+] + gtest_args + sys.argv[1:]
 
 print 'gtest-parallel-wrapper: Executing command %s' % ' '.join(command)
 sys.stdout.flush()
 
 sys.exit(subprocess.call(command, env=test_env, cwd=os.getcwd()))