Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1165)

Issue 2558463002: Reland of H.264 packetization mode 0 (try 3) (Closed)

Created:
4 years ago by hta-webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, perkj_webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of H.264 packetization mode 0 (try 3) (patchset #1 id:1 of https://codereview.webrtc.org/2558453002/ ) Reason for revert: Fixed timeouts in slow tests Original issue's description: > Revert of H.264 packetization mode 0 (try 3) (patchset #13 id:490001 of https://codereview.webrtc.org/2528343002/ ) > > Reason for revert: > Failures on the Linux Memcheck bot > > Original issue's description: > > This approach passes packetization mode to the encoder as part of > > a cricket::VideoCodec structure, rather than as part of struct VideoCodecH264 inside webrtc::VideoCodec. > > > > BUG=600254 > > > > Committed: https://crrev.com/e59647b991f61cf1cf61b020356705e6c0f81257 > > Cr-Commit-Position: refs/heads/master@{#15437} > > TBR=hbos@webrtc.org,sprang@webrtc.org,mflodman@webrtc.org,magjed@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=600254 > > Committed: https://crrev.com/243a0a7a7fd6b5da1e32df31f1bfbb6a68dc09f3 > Cr-Commit-Position: refs/heads/master@{#15441} TBR=hbos@webrtc.org,sprang@webrtc.org,mflodman@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=600254 Committed: https://crrev.com/9aa96889a333925e7c0ff4fa1b2898e001f3001f Cr-Commit-Position: refs/heads/master@{#15445}

Patch Set 1 #

Patch Set 2 : Lengthened timeout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -68 lines) Patch
M webrtc/media/base/codec.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/media/base/codec.cc View 1 2 chunks +16 lines, -3 lines 0 comments Download
M webrtc/media/engine/internalencoderfactory.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/include/module_common_types.h View 1 2 chunks +19 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format.cc View 1 2 chunks +8 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc View 1 4 chunks +34 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc View 1 13 chunks +97 lines, -26 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h View 1 4 chunks +9 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 1 9 chunks +55 lines, -13 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/h264_encoder_impl_unittest.cc View 1 chunk +83 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/include/video_codec_interface.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/test/fake_encoder.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 2 chunks +20 lines, -1 line 0 comments Download
M webrtc/video/payload_router.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
hta-webrtc
Created Reland of H.264 packetization mode 0 (try 3)
4 years ago (2016-12-06 13:00:19 UTC) #1
hbos
lgtm
4 years ago (2016-12-06 13:11:51 UTC) #2
sprang_webrtc
lgtm
4 years ago (2016-12-06 13:16:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2558463002/270001
4 years ago (2016-12-06 13:35:56 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:270001)
4 years ago (2016-12-06 13:36:07 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-06 13:36:19 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9aa96889a333925e7c0ff4fa1b2898e001f3001f
Cr-Commit-Position: refs/heads/master@{#15445}

Powered by Google App Engine
This is Rietveld 408576698