Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Unified Diff: webrtc/video/end_to_end_tests.cc

Issue 2558463002: Reland of H.264 packetization mode 0 (try 3) (Closed)
Patch Set: Lengthened timeout Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/BUILD.gn ('k') | webrtc/video/payload_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/end_to_end_tests.cc
diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc
index 4de6db49cdc7d36c8b9b0b58ae715263ef56098d..9d37e28f870d40c7243b2462d6d6894eb10f5f49 100644
--- a/webrtc/video/end_to_end_tests.cc
+++ b/webrtc/video/end_to_end_tests.cc
@@ -314,7 +314,9 @@ class CodecObserver : public test::EndToEndTest,
const std::string& payload_name,
webrtc::VideoEncoder* encoder,
webrtc::VideoDecoder* decoder)
- : EndToEndTest(2 * webrtc::EndToEndTest::kDefaultTimeoutMs),
+ : EndToEndTest(4 * webrtc::EndToEndTest::kDefaultTimeoutMs),
+ // TODO(hta): This timeout (120 seconds) is excessive.
+ // https://bugs.webrtc.org/6830
no_frames_to_wait_for_(no_frames_to_wait_for),
expected_rotation_(rotation_to_test),
payload_name_(payload_name),
@@ -404,6 +406,23 @@ TEST_P(EndToEndTest, SendsAndReceivesH264VideoRotation90) {
H264Decoder::Create());
RunBaseTest(&test);
}
+
+TEST_P(EndToEndTest, SendsAndReceivesH264PacketizationMode0) {
+ cricket::VideoCodec codec = cricket::VideoCodec("H264");
+ codec.SetParam(cricket::kH264FmtpPacketizationMode, "0");
+ CodecObserver test(500, kVideoRotation_0, "H264", H264Encoder::Create(codec),
+ H264Decoder::Create());
+ RunBaseTest(&test);
+}
+
+TEST_P(EndToEndTest, SendsAndReceivesH264PacketizationMode1) {
+ cricket::VideoCodec codec = cricket::VideoCodec("H264");
+ codec.SetParam(cricket::kH264FmtpPacketizationMode, "1");
+ CodecObserver test(500, kVideoRotation_0, "H264", H264Encoder::Create(codec),
+ H264Decoder::Create());
+ RunBaseTest(&test);
+}
+
#endif // defined(WEBRTC_USE_H264)
TEST_P(EndToEndTest, ReceiverUsesLocalSsrc) {
« no previous file with comments | « webrtc/video/BUILD.gn ('k') | webrtc/video/payload_router.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698