Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2558453002: Revert of H.264 packetization mode 0 (try 3) (Closed)

Created:
4 years ago by hta-webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, perkj_webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of H.264 packetization mode 0 (try 3) (patchset #13 id:490001 of https://codereview.webrtc.org/2528343002/ ) Reason for revert: Failures on the Linux Memcheck bot Original issue's description: > This approach passes packetization mode to the encoder as part of > a cricket::VideoCodec structure, rather than as part of struct VideoCodecH264 inside webrtc::VideoCodec. > > BUG=600254 > > Committed: https://crrev.com/e59647b991f61cf1cf61b020356705e6c0f81257 > Cr-Commit-Position: refs/heads/master@{#15437} TBR=hbos@webrtc.org,sprang@webrtc.org,mflodman@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=600254 Committed: https://crrev.com/243a0a7a7fd6b5da1e32df31f1bfbb6a68dc09f3 Cr-Commit-Position: refs/heads/master@{#15441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -361 lines) Patch
M webrtc/media/base/codec.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/media/base/codec.cc View 2 chunks +4 lines, -17 lines 0 comments Download
M webrtc/media/engine/internalencoderfactory.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/include/module_common_types.h View 2 chunks +5 lines, -19 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.h View 2 chunks +1 line, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc View 4 chunks +8 lines, -34 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc View 13 chunks +26 lines, -97 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h View 4 chunks +2 lines, -9 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 9 chunks +13 lines, -55 lines 0 comments Download
D webrtc/modules/video_coding/codecs/h264/h264_encoder_impl_unittest.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M webrtc/modules/video_coding/include/video_codec_interface.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/test/fake_encoder.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/video/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M webrtc/video/payload_router.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
hta-webrtc
Created Revert of H.264 packetization mode 0 (try 3)
4 years ago (2016-12-06 12:21:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2558453002/1
4 years ago (2016-12-06 12:21:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 12:22:02 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/243a0a7a7fd6b5da1e32df31f1bfbb6a68dc09f3 Cr-Commit-Position: refs/heads/master@{#15441}
4 years ago (2016-12-06 12:22:16 UTC) #8
hta-webrtc
4 years ago (2016-12-06 13:00:18 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2558463002/ by hta@webrtc.org.

The reason for reverting is: Fixed timeouts in slow tests.

Powered by Google App Engine
This is Rietveld 408576698