Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: webrtc/modules/include/module_common_types.h

Issue 2558453002: Revert of H.264 packetization mode 0 (try 3) (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/BUILD.gn ('k') | webrtc/modules/rtp_rtcp/source/rtp_format.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/include/module_common_types.h
diff --git a/webrtc/modules/include/module_common_types.h b/webrtc/modules/include/module_common_types.h
index 3df93b6c89a050fb05603a0d5987a2a7c982a2d8..5de5eb78f6f719a50cda90d1a4fc292bf2084b24 100644
--- a/webrtc/modules/include/module_common_types.h
+++ b/webrtc/modules/include/module_common_types.h
@@ -262,15 +262,6 @@
// that was too large to fit into a single packet.
};
-// Packetization modes are defined in RFC 6184 section 6
-// Due to the structure containing this being initialized with zeroes
-// in some places, and mode 1 being default, mode 1 needs to have the value
-// zero. https://crbug.com/webrtc/6803
-enum class H264PacketizationMode {
- NonInterleaved = 0, // Mode 1 - STAP-A, FU-A is allowed
- SingleNalUnit // Mode 0 - only single NALU allowed
-};
-
struct NaluInfo {
uint8_t type;
int sps_id;
@@ -284,19 +275,14 @@
const size_t kMaxNalusPerPacket = 10;
struct RTPVideoHeaderH264 {
- // The NAL unit type. If this is a header for a
- // fragmented packet, it's the NAL unit type of
- // the original data. If this is the header for an
- // aggregated packet, it's the NAL unit type of
- // the first NAL unit in the packet.
- uint8_t nalu_type;
- // The packetization type of this buffer - single, aggregated or fragmented.
+ uint8_t nalu_type; // The NAL unit type. If this is a header for a
+ // fragmented packet, it's the NAL unit type of
+ // the original data. If this is the header for an
+ // aggregated packet, it's the NAL unit type of
+ // the first NAL unit in the packet.
H264PacketizationTypes packetization_type;
NaluInfo nalus[kMaxNalusPerPacket];
size_t nalus_length;
- // The packetization mode of this transport. Packetization mode
- // determines which packetization types are allowed when packetizing.
- H264PacketizationMode packetization_mode;
};
union RTPVideoTypeHeader {
« no previous file with comments | « webrtc/modules/BUILD.gn ('k') | webrtc/modules/rtp_rtcp/source/rtp_format.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698