Add disabled certificate check support to IceServer PeerConnection API.

webrtc/p2p/base/port.cc

Index: webrtc/p2p/base/port.cc
diff --git a/webrtc/p2p/base/port.cc b/webrtc/p2p/base/port.cc
index b9ead32b543525ae571e46b72d1ab392c2d5afda..eb63436dc8d83806e60d12aab074a5bf0094e4ee 100644
--- a/webrtc/p2p/base/port.cc
+++ b/webrtc/p2p/base/port.cc
@@ -89,10 +89,11 @@ const char RELAY_PORT_TYPE[] = "relay";
 const char UDP_PROTOCOL_NAME[] = "udp";
 const char TCP_PROTOCOL_NAME[] = "tcp";
 const char SSLTCP_PROTOCOL_NAME[] = "ssltcp";
+const char TLS_PROTOCOL_NAME[] = "tls";
 
-static const char* const PROTO_NAMES[] = { UDP_PROTOCOL_NAME,
-                                           TCP_PROTOCOL_NAME,
-                                           SSLTCP_PROTOCOL_NAME };
+static const char* const PROTO_NAMES[] = {UDP_PROTOCOL_NAME, TCP_PROTOCOL_NAME,
+                                          SSLTCP_PROTOCOL_NAME,
+                                          TLS_PROTOCOL_NAME};

[pthatcher1, 2016/12/07 21:29:35]

We should probably document what these things mean.  First, that they are used
for ICE candidate protocol and ICE candidate relay protocol.  UDP and TCP are
clear.  SSLTCP means to use a "fake SSL" connection over TCP (see
AsyncSSLSocket).  This new thing (TLS) is real TLS over TCP.  But it's only used
by the ICE candidate relay protocol, not ICE candidate protocol.  In other
words, we have it implemented in turnport.cc, but not tcpport.cc.

[Taylor Brandstetter, 2016/12/08 01:36:40]

I agree about documenting what these things mean. But we should document how
they're used in the places they're used, separately.

[hnsl1, 2016/12/12 16:08:13]

I agree there are different meanings here that should be documented and possibly
cleaned up. If tcpport ends up having some other meaning of "tls" it can fork
the ProtocolType type into a new type. For now this should not affect tcpport
since SupportsProtocol() will return false for "tls" candidates. But I think
this cleanup and documentation can be added in a future CL. The different
meanings where already there before this CL (candidate protocol vs relay client
protocol).

 
 const char* ProtoToString(ProtocolType proto) {
   return PROTO_NAMES[proto];