Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Unified Diff: webrtc/api/peerconnectioninterface.h

Issue 2557803002: Add disabled certificate check support to IceServer PeerConnection API. (Closed)
Patch Set: Add disabled certificate check support to IceServer PeerConnection API. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/peerconnectioninterface.h
diff --git a/webrtc/api/peerconnectioninterface.h b/webrtc/api/peerconnectioninterface.h
index 54fae2b71107398b6938e1b4c2797c00044ce4c8..02875cc3766cbe487c2770ef16281c0c3e3c9b61 100644
--- a/webrtc/api/peerconnectioninterface.h
+++ b/webrtc/api/peerconnectioninterface.h
@@ -169,12 +169,18 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
kIceConnectionMax,
};
+ enum TlsCertificatePolicy {
+ kTlsCertPolicySecure,
+ kTlsCertPolicyInsecureNoCheck,
Taylor Brandstetter 2016/12/08 01:36:40 Add comments explaining what each of these values
hnsl1 2016/12/12 16:08:13 Done.
+ };
+
struct IceServer {
// TODO(jbauch): Remove uri when all code using it has switched to urls.
std::string uri;
std::vector<std::string> urls;
std::string username;
std::string password;
+ TlsCertificatePolicy tls_certificate_policy;
pthatcher1 2016/12/07 21:29:35 Again, this shouldn't be an ICE server attribute.
Taylor Brandstetter 2016/12/08 01:36:40 I'd have this default to kTlsCertPolicySecure, as
hnsl1 2016/12/12 16:08:13 Done.
hnsl1 2016/12/12 16:08:13 Nack, see my other response about API design.
};
typedef std::vector<IceServer> IceServers;

Powered by Google App Engine
This is Rietveld 408576698