Add disabled certificate check support to IceServer PeerConnection API.

webrtc/api/peerconnectioninterface.h

 /*
  *  Copyright 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 151 matching lines @@
     kIceConnectionNew,
     kIceConnectionChecking,
     kIceConnectionConnected,
     kIceConnectionCompleted,
     kIceConnectionFailed,
     kIceConnectionDisconnected,
     kIceConnectionClosed,
     kIceConnectionMax,
   };
 
+  enum TlsCertificatePolicy {
+    kTlsCertPolicySecure,
+    kTlsCertPolicyInsecureNoCheck,

[Taylor Brandstetter, 2016/12/08 01:36:40]

Add comments explaining what each of these values implies.

[hnsl1, 2016/12/12 16:08:13]

Done.

+  };
+
   struct IceServer {
     // TODO(jbauch): Remove uri when all code using it has switched to urls.
     std::string uri;
     std::vector<std::string> urls;
     std::string username;
     std::string password;
+    TlsCertificatePolicy tls_certificate_policy;

[pthatcher1, 2016/12/07 21:29:35]

Again, this shouldn't be an ICE server attribute.  It should be something passed
in from PeerConnection's RTCConfig that then goes down into the PortAllocator. 
There are a lot of similar such things, as you can see here:

https://cs.chromium.org/chromium/src/third_party/webrtc/api/peerconnection.cc...

[Taylor Brandstetter, 2016/12/08 01:36:40]

I'd have this default to kTlsCertPolicySecure, as an extra precaution.

[hnsl1, 2016/12/12 16:08:13]

Done.

[hnsl1, 2016/12/12 16:08:13]

Nack, see my other response about API design.

   };
   typedef std::vector<IceServer> IceServers;
 
   enum IceTransportsType {
     // TODO(pthatcher): Rename these kTransporTypeXXX, but update
     // Chromium at the same time.
     kNone,
     kRelay,
     kNoHost,
     kAll
@@ skipping 581 matching lines @@
     cricket::WebRtcVideoEncoderFactory* encoder_factory,
     cricket::WebRtcVideoDecoderFactory* decoder_factory) {
   return CreatePeerConnectionFactory(
       worker_and_network_thread, worker_and_network_thread, signaling_thread,
       default_adm, encoder_factory, decoder_factory);
 }
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_API_PEERCONNECTIONINTERFACE_H_