Add method needed to extract frame capture and arrival timestamps from rtc event logs.

Add method needed to extract frame capture and arrival timestamps from rtc event logs.

BUG=None

Review-Url: https://codereview.webrtc.org/2557073002
Cr-Commit-Position: refs/heads/master@{#15717}
Committed: https://chromium.googlesource.com/external/webrtc/+/0838327ec96993a7ff3459bb3588203b6ccfc260

[stefan-webrtc, 2016-12-20 15:15:54]

Description was changed from

==========
Add script and modifications to build feature vector.

BUG=None
==========

to

==========
Add method needed to extract frame capture and arrival timestamps from rtc event
logs.

BUG=None
==========

[stefan-webrtc, 2016-12-20 15:17:00]

stefan@webrtc.org changed reviewers:
+ terelius@webrtc.org

[stefan-webrtc, 2016-12-20 15:18:31]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 15:18:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[terelius, 2016-12-20 15:25:08]

https://codereview.webrtc.org/2557073002/diff/120001/webrtc/tools/event_log_v...
File webrtc/tools/event_log_visualizer/analyzer.cc (right):

https://codereview.webrtc.org/2557073002/diff/120001/webrtc/tools/event_log_v...
webrtc/tools/event_log_visualizer/analyzer.cc:1187: return
std::vector<int64_t>();
Maybe:
if (largest_video_stream != nullptr) {
  for (auto& packet : *largest_video_stream) {...}
}

WDYT?

https://codereview.webrtc.org/2557073002/diff/120001/webrtc/tools/event_log_v...
webrtc/tools/event_log_visualizer/analyzer.cc:1191:
timestamps.push_back(capture_ms);
I think it would be nicer if timestamps was a vector of pairs.

[stefan-webrtc, 2016-12-20 15:28:39]

https://codereview.webrtc.org/2557073002/diff/120001/webrtc/tools/event_log_v...
File webrtc/tools/event_log_visualizer/analyzer.cc (right):

https://codereview.webrtc.org/2557073002/diff/120001/webrtc/tools/event_log_v...
webrtc/tools/event_log_visualizer/analyzer.cc:1187: return
std::vector<int64_t>();
On 2016/12/20 15:25:08, terelius wrote:
> Maybe:
> if (largest_video_stream != nullptr) {
>   for (auto& packet : *largest_video_stream) {...}
> }
> 
> WDYT?

Done.

https://codereview.webrtc.org/2557073002/diff/120001/webrtc/tools/event_log_v...
webrtc/tools/event_log_visualizer/analyzer.cc:1191:
timestamps.push_back(capture_ms);
On 2016/12/20 15:25:08, terelius wrote:
> I think it would be nicer if timestamps was a vector of pairs.

Done.

[stefan-webrtc, 2016-12-20 15:29:22]

Comments addressed.

[terelius, 2016-12-20 15:30:02]

lgtm

[stefan-webrtc, 2016-12-20 15:34:46]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2016-12-20 15:34:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-20 16:51:53]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1482248086605250,
"parent_rev": "f7969df2d9e4e941a02afc05983e8dbfbad9f6f9", "commit_rev":
"0838327ec96993a7ff3459bb3588203b6ccfc260"}

[commit-bot: I haz the power, 2016-12-20 16:51:55]

Description was changed from

==========
Add method needed to extract frame capture and arrival timestamps from rtc event
logs.

BUG=None
==========

to

==========
Add method needed to extract frame capture and arrival timestamps from rtc event
logs.

BUG=None

Review-Url: https://codereview.webrtc.org/2557073002
Cr-Commit-Position: refs/heads/master@{#15717}
Committed:
https://chromium.googlesource.com/external/webrtc/+/0838327ec96993a7ff3459bb3...
==========

[commit-bot: I haz the power, 2016-12-20 16:51:56]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/external/webrtc/+/0838327ec96993a7ff3459bb3...