Move all codec specific definitions from modules_include

Move all codec specific definitions from modules_include

This CL moves all codec specific definitions into their own
header files in the respective codec directory, and replaces
it with an include in the top level directory.

This is to facilitate getting the code out of the header files.

No behavioral changes are expected.

BUG=webrtc:6842
Committed: https://crrev.com/41286496cbf61c2ab66b2df243e00c206995de39
Cr-Commit-Position: refs/heads/master@{#15623}

[hta-webrtc, 2016-12-07 09:42:20]

hta@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[hta-webrtc, 2016-12-07 09:42:21]

I took a whack at moving the defs around. Looks clean to me, but it does
introduce a formal dependency from modules/include into the various codec
modules.

In my opinion, the dependency only makes obvious what was already there, but
YMMV.

[kwiberg-webrtc, 2016-12-07 09:58:22]

kwiberg@webrtc.org changed reviewers:
+ stefan@webrtc.org

[kwiberg-webrtc, 2016-12-07 09:58:22]

Reassigning to a video_coding/codecs owner. Stefan, feel free to pass the hot
potato on if I tossed it to the wrong person...

[hta-webrtc, 2016-12-09 09:48:10]

Stefan: The trigger for this came from https://codereview.webrtc.org/2554003002/
where I added yet another inline function to this file just because it didn't
have a .cc to live in.

This seems wrong, so I made a bug for it - but before I attack that one, I'd
like to move the stuff from the .h to a directory where it belongs.

Those who care about directory structures should likely have an opinion on this
move; there are no code changes.

[stefan-webrtc, 2016-12-13 09:35:49]

Seems like a good change.

lgtm, but take a look at my comment and see if you can improve.

https://codereview.webrtc.org/2555993003/diff/1/webrtc/modules/include/module...
File webrtc/modules/include/module_common_constants.h (right):

https://codereview.webrtc.org/2555993003/diff/1/webrtc/modules/include/module...
webrtc/modules/include/module_common_constants.h:12: // codec definitions
(modules/video_coding/codecs/*/include/*_globals.h)
The reason this is placed under modules/include/... is because it's used by both
modules/rtp_rtcp and modules/video_coding. This comment makes it sound a bit
like they should be placed under modules/video_coding/codecs/... instead?

[hta-webrtc, 2016-12-13 14:03:04]

Does this look better?

https://codereview.webrtc.org/2555993003/diff/1/webrtc/modules/include/module...
File webrtc/modules/include/module_common_constants.h (right):

https://codereview.webrtc.org/2555993003/diff/1/webrtc/modules/include/module...
webrtc/modules/include/module_common_constants.h:12: // codec definitions
(modules/video_coding/codecs/*/include/*_globals.h)
On 2016/12/13 09:35:49, stefan-webrtc (holmer) wrote:
> The reason this is placed under modules/include/... is because it's used by
both
> modules/rtp_rtcp and modules/video_coding. This comment makes it sound a bit
> like they should be placed under modules/video_coding/codecs/... instead?

Sounds better to me.

[hta-webrtc, 2016-12-13 14:03:19]

The CQ bit was checked by hta@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 14:03:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-13 14:22:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 14:22:16]

Dry run: This issue passed the CQ dry run.

[stefan-webrtc, 2016-12-15 08:25:52]

lgtm

[hta-webrtc, 2016-12-15 08:31:21]

The CQ bit was checked by hta@webrtc.org

[commit-bot: I haz the power, 2016-12-15 08:31:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-15 08:54:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481790681033730,
"parent_rev": "3b86e1ef629c5a026a2a657e5fe9e6f47771e7fa", "commit_rev":
"5a900c7eac972739ab1dbddbb69d78476b738c49"}

[commit-bot: I haz the power, 2016-12-15 08:54:10]

Description was changed from

==========
Move all codec specific definitions from modules_include

This CL moves all codec specific definitions into their own
header files in the respective codec directory, and replaces
it with an include in the top level directory.

This is to facilitate getting the code out of the header files.

No behavioral changes are expected.

BUG=webrtc:6842
==========

to

==========
Move all codec specific definitions from modules_include

This CL moves all codec specific definitions into their own
header files in the respective codec directory, and replaces
it with an include in the top level directory.

This is to facilitate getting the code out of the header files.

No behavioral changes are expected.

BUG=webrtc:6842

Review-Url: https://codereview.webrtc.org/2555993003
==========

[commit-bot: I haz the power, 2016-12-15 08:54:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-15 08:54:22]

Description was changed from

==========
Move all codec specific definitions from modules_include

This CL moves all codec specific definitions into their own
header files in the respective codec directory, and replaces
it with an include in the top level directory.

This is to facilitate getting the code out of the header files.

No behavioral changes are expected.

BUG=webrtc:6842

Review-Url: https://codereview.webrtc.org/2555993003
==========

to

==========
Move all codec specific definitions from modules_include

This CL moves all codec specific definitions into their own
header files in the respective codec directory, and replaces
it with an include in the top level directory.

This is to facilitate getting the code out of the header files.

No behavioral changes are expected.

BUG=webrtc:6842

Committed: https://crrev.com/41286496cbf61c2ab66b2df243e00c206995de39
Cr-Commit-Position: refs/heads/master@{#15623}
==========

[commit-bot: I haz the power, 2016-12-15 08:54:23]

Patchset 3 (id:??) landed as
https://crrev.com/41286496cbf61c2ab66b2df243e00c206995de39
Cr-Commit-Position: refs/heads/master@{#15623}