Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2553683008: Add ifdef protection for iOS-only headers (Closed)

Created:
4 years ago by afedor
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, daniela-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add ifdef protection for iOS-only headers BUG=webrtc:6841 Review-Url: https://codereview.webrtc.org/2553683008 Cr-Commit-Position: refs/heads/master@{#16580} Committed: https://chromium.googlesource.com/external/webrtc/+/806a1a0c2815ece748db845e54efae5b8e3d6730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M webrtc/sdk/objc/Framework/Headers/WebRTC/WebRTC.h View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kthelgason
Zeke, please take a look if you have time.
4 years ago (2016-12-08 09:21:21 UTC) #2
kthelgason
denicija: FYI. afedor: This lgtm, but tkchin@ knows better than I do which headers should ...
4 years ago (2016-12-19 12:12:26 UTC) #3
kthelgason
Magjed, PTAL.
3 years, 10 months ago (2017-02-09 09:27:16 UTC) #5
magjed_webrtc
lgtm
3 years, 10 months ago (2017-02-13 12:07:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2553683008/1
3 years, 10 months ago (2017-02-13 12:07:19 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 13:09:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/806a1a0c2815ece748db845e5...

Powered by Google App Engine
This is Rietveld 408576698