Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2551603003: Modify the parameter type of PeerConnectionObserver callback OnAddTrack. (Closed)

Created:
4 years ago by Zhi Huang
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Modify the parameter type of PeerConnectionObserver callback OnAddTrack. Change the second parameter type to a const reference of vector so that the vector will not be copied. BUG=none Committed: https://crrev.com/c63b89468682eef761a6d444d1fd6445d7a624ed Cr-Commit-Position: refs/heads/master@{#15396}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M webrtc/api/peerconnectioninterface.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Zhi Huang
Please take a look.
4 years ago (2016-12-02 23:23:06 UTC) #4
Taylor Brandstetter
lgtm; I'd suggest changing the commit messages to be a max of 76 characters long ...
4 years ago (2016-12-02 23:24:52 UTC) #5
Zhi Huang
On 2016/12/02 23:24:52, Taylor Brandstetter wrote: > lgtm; I'd suggest changing the commit messages to ...
4 years ago (2016-12-02 23:28:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2551603003/1
4 years ago (2016-12-02 23:39:36 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 23:41:14 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-02 23:41:24 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c63b89468682eef761a6d444d1fd6445d7a624ed
Cr-Commit-Position: refs/heads/master@{#15396}

Powered by Google App Engine
This is Rietveld 408576698