Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Side by Side Diff: webrtc/api/peerconnectioninterface.h

Issue 2551603003: Modify the parameter type of PeerConnectionObserver callback OnAddTrack. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/api/peerconnectioninterface_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 585 matching lines...) Expand 10 before | Expand all | Expand 10 after
596 const std::vector<cricket::Candidate>& candidates) {} 596 const std::vector<cricket::Candidate>& candidates) {}
597 597
598 // Called when the ICE connection receiving status changes. 598 // Called when the ICE connection receiving status changes.
599 virtual void OnIceConnectionReceivingChange(bool receiving) {} 599 virtual void OnIceConnectionReceivingChange(bool receiving) {}
600 600
601 // Called when a track is added to streams. 601 // Called when a track is added to streams.
602 // TODO(zhihuang) Make this a pure virtual method when all its subclasses 602 // TODO(zhihuang) Make this a pure virtual method when all its subclasses
603 // implement it. 603 // implement it.
604 virtual void OnAddTrack( 604 virtual void OnAddTrack(
605 rtc::scoped_refptr<RtpReceiverInterface> receiver, 605 rtc::scoped_refptr<RtpReceiverInterface> receiver,
606 std::vector<rtc::scoped_refptr<MediaStreamInterface>> streams) {} 606 const std::vector<rtc::scoped_refptr<MediaStreamInterface>>& streams) {}
607 607
608 protected: 608 protected:
609 // Dtor protected as objects shouldn't be deleted via this interface. 609 // Dtor protected as objects shouldn't be deleted via this interface.
610 ~PeerConnectionObserver() {} 610 ~PeerConnectionObserver() {}
611 }; 611 };
612 612
613 // PeerConnectionFactoryInterface is the factory interface use for creating 613 // PeerConnectionFactoryInterface is the factory interface use for creating
614 // PeerConnection, MediaStream and media tracks. 614 // PeerConnection, MediaStream and media tracks.
615 // PeerConnectionFactoryInterface will create required libjingle threads, 615 // PeerConnectionFactoryInterface will create required libjingle threads,
616 // socket and network manager factory classes for networking. 616 // socket and network manager factory classes for networking.
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
769 cricket::WebRtcVideoEncoderFactory* encoder_factory, 769 cricket::WebRtcVideoEncoderFactory* encoder_factory,
770 cricket::WebRtcVideoDecoderFactory* decoder_factory) { 770 cricket::WebRtcVideoDecoderFactory* decoder_factory) {
771 return CreatePeerConnectionFactory( 771 return CreatePeerConnectionFactory(
772 worker_and_network_thread, worker_and_network_thread, signaling_thread, 772 worker_and_network_thread, worker_and_network_thread, signaling_thread,
773 default_adm, encoder_factory, decoder_factory); 773 default_adm, encoder_factory, decoder_factory);
774 } 774 }
775 775
776 } // namespace webrtc 776 } // namespace webrtc
777 777
778 #endif // WEBRTC_API_PEERCONNECTIONINTERFACE_H_ 778 #endif // WEBRTC_API_PEERCONNECTIONINTERFACE_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/api/peerconnectioninterface_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698