Refactor fileutils.cc/h and fileutils_unittests.cc into their own targets.

Refactor fileutils.cc/h and fileutils_unittests.cc into their own targets.

This will allow for custom implementations downstream.

R=kjellander@webrtc.org, phoglund@webrtc.org
BUG=webrtc:6727
Committed: https://crrev.com/37535bfb7fcb46df9382e6976ce9ac99c3fb1c3e
Cr-Commit-Position: refs/heads/master@{#15423}

[ehmaldonado_webrtc, 2016-12-02 14:27:37]

Description was changed from

==========
Refactor fileutils.cc/h and fileutils_unittests.cc into their own targets.

This will allow for custom implementations downstream.

R=kjellander@webrtc.org, phoglund@webrtc.org
BUG=
==========

to

==========
Refactor fileutils.cc/h and fileutils_unittests.cc into their own targets.

This will allow for custom implementations downstream.

R=kjellander@webrtc.org, phoglund@webrtc.org
BUG=webrtc:6727
==========

[ehmaldonado_webrtc, 2016-12-02 14:28:42]

The idea is to implement target translation downstream, so we could replace
every occurrence of the target "fileutils" with "fileutils_internal" or
something.

[kjellander_webrtc, 2016-12-02 14:31:08]

https://codereview.webrtc.org/2548713003/diff/1/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2548713003/diff/1/webrtc/test/BUILD.gn#newcode391
webrtc/test/BUILD.gn:391: rtc_source_set("fileutils") {
Move these closer to the reference

[ehmaldonado_webrtc, 2016-12-02 14:39:17]

On 2016/12/02 14:31:08, kjellander_webrtc wrote:
> https://codereview.webrtc.org/2548713003/diff/1/webrtc/test/BUILD.gn
> File webrtc/test/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2548713003/diff/1/webrtc/test/BUILD.gn#newcode391
> webrtc/test/BUILD.gn:391: rtc_source_set("fileutils") {
> Move these closer to the reference

PTAL

[kjellander_webrtc, 2016-12-02 14:40:40]

https://codereview.webrtc.org/2548713003/diff/20001/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2548713003/diff/20001/webrtc/test/BUILD.gn#newc...
webrtc/test/BUILD.gn:115: rtc_source_set("fileutils_unittests") {
Please move to below test_support_unittests

https://codereview.webrtc.org/2548713003/diff/20001/webrtc/test/BUILD.gn#newc...
webrtc/test/BUILD.gn:127: suppressed_configs += [
"//build/config/clang:find_bad_constructs" ]
Is this one needed? With just so few files, it would be nice to fix the warnings
instead.

[ehmaldonado_webrtc, 2016-12-02 15:58:39]

On 2016/12/02 14:40:40, kjellander_webrtc wrote:
> https://codereview.webrtc.org/2548713003/diff/20001/webrtc/test/BUILD.gn
> File webrtc/test/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2548713003/diff/20001/webrtc/test/BUILD.gn#newc...
> webrtc/test/BUILD.gn:115: rtc_source_set("fileutils_unittests") {
> Please move to below test_support_unittests
> 
>
https://codereview.webrtc.org/2548713003/diff/20001/webrtc/test/BUILD.gn#newc...
> webrtc/test/BUILD.gn:127: suppressed_configs += [
> "//build/config/clang:find_bad_constructs" ]
> Is this one needed? With just so few files, it would be nice to fix the
warnings
> instead.

I had expected it to be harder to fix... If this is the only thing we should do
to get rid of that suppression, it might be worth doing.
PTAL

[ehmaldonado_webrtc, 2016-12-02 15:58:41]

On 2016/12/02 14:40:40, kjellander_webrtc wrote:
> https://codereview.webrtc.org/2548713003/diff/20001/webrtc/test/BUILD.gn
> File webrtc/test/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2548713003/diff/20001/webrtc/test/BUILD.gn#newc...
> webrtc/test/BUILD.gn:115: rtc_source_set("fileutils_unittests") {
> Please move to below test_support_unittests
> 
>
https://codereview.webrtc.org/2548713003/diff/20001/webrtc/test/BUILD.gn#newc...
> webrtc/test/BUILD.gn:127: suppressed_configs += [
> "//build/config/clang:find_bad_constructs" ]
> Is this one needed? With just so few files, it would be nice to fix the
warnings
> instead.

I had expected it to be harder to fix... If this is the only thing we should do
to get rid of that suppression, it might be worth doing.
PTAL

[phoglund, 2016-12-02 16:03:54]

https://codereview.webrtc.org/2548713003/diff/40001/webrtc/build/webrtc.gni
File webrtc/build/webrtc.gni (right):

https://codereview.webrtc.org/2548713003/diff/40001/webrtc/build/webrtc.gni#n...
webrtc/build/webrtc.gni:19: rtc_use_default_fileutils = true
Wut? But this variable is never read in your patch.

[ehmaldonado_webrtc, 2016-12-02 16:45:52]

https://codereview.webrtc.org/2548713003/diff/40001/webrtc/build/webrtc.gni
File webrtc/build/webrtc.gni (right):

https://codereview.webrtc.org/2548713003/diff/40001/webrtc/build/webrtc.gni#n...
webrtc/build/webrtc.gni:19: rtc_use_default_fileutils = true
On 2016/12/02 16:03:54, phoglund wrote:
> Wut? But this variable is never read in your patch.

Forgot to revert. Sorry.

[kjellander_webrtc, 2016-12-02 20:45:32]

lgtm!

[ehmaldonado_webrtc, 2016-12-02 22:01:57]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2016-12-02 22:02:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-02 22:04:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 22:04:06]

Try jobs failed on following builders:
  android_compile_x86_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_rel...)
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/19032)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/19390)
  linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds...)

[ehmaldonado_webrtc, 2016-12-02 22:26:24]

The CQ bit was checked by ehmaldonado@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 22:26:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-02 22:33:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 22:33:34]

Dry run: Try jobs failed on following builders:
  win_x64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/20302)

[ehmaldonado_webrtc, 2016-12-02 22:52:00]

Patchset #6 (id:100001) has been deleted

[ehmaldonado_webrtc, 2016-12-02 22:52:07]

Patchset #6 (id:120001) has been deleted

[ehmaldonado_webrtc, 2016-12-02 23:11:48]

On 2016/12/02 22:04:06, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_compile_x86_rel on master.tryserver.webrtc (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_rel...)
>   android_rel on master.tryserver.webrtc (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/19032)
>   ios_rel on master.tryserver.webrtc (JOB_FAILED,
> http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/19390)
>   linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds...)

PTAL. I made a couple of changes.

[kjellander_webrtc, 2016-12-03 17:06:37]

https://codereview.webrtc.org/2548713003/diff/140001/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2548713003/diff/140001/webrtc/test/BUILD.gn#new...
webrtc/test/BUILD.gn:157: sources += [ "testsupport/iosfileutils.mm" ]
Shouldn't this be in the fileutils target?

[ehmaldonado_webrtc, 2016-12-05 11:57:39]

On 2016/12/03 17:06:37, kjellander_webrtc wrote:
> https://codereview.webrtc.org/2548713003/diff/140001/webrtc/test/BUILD.gn
> File webrtc/test/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2548713003/diff/140001/webrtc/test/BUILD.gn#new...
> webrtc/test/BUILD.gn:157: sources += [ "testsupport/iosfileutils.mm" ]
> Shouldn't this be in the fileutils target?

Right. PTAL.

[phoglund, 2016-12-05 13:36:49]

lgtm

[kjellander_webrtc, 2016-12-05 13:38:23]

lgtm

[ehmaldonado_webrtc, 2016-12-05 13:53:05]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2016-12-05 13:53:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-05 13:56:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 13:56:46]

Try jobs failed on following builders:
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/20703)

[ehmaldonado_webrtc, 2016-12-05 14:27:07]

The CQ bit was checked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2016-12-05 14:27:07]

The patchset sent to the CQ was uploaded after l-g-t-m from phoglund@webrtc.org,
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2548713003/#ps180001 (title:
"Fix iOS compile error.")

[commit-bot: I haz the power, 2016-12-05 14:27:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-05 14:42:46]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1480948027199150,
"parent_rev": "a69d4a754403610334f97b038234c127d9905eae", "commit_rev":
"6bfb83bbc20fe48f6fbebb17dbba46fa8c2252c6"}

[commit-bot: I haz the power, 2016-12-05 14:42:48]

Description was changed from

==========
Refactor fileutils.cc/h and fileutils_unittests.cc into their own targets.

This will allow for custom implementations downstream.

R=kjellander@webrtc.org, phoglund@webrtc.org
BUG=webrtc:6727
==========

to

==========
Refactor fileutils.cc/h and fileutils_unittests.cc into their own targets.

This will allow for custom implementations downstream.

R=kjellander@webrtc.org, phoglund@webrtc.org
BUG=webrtc:6727
==========

[commit-bot: I haz the power, 2016-12-05 14:42:50]

Committed patchset #8 (id:180001)

[commit-bot: I haz the power, 2016-12-05 14:42:53]

Description was changed from

==========
Refactor fileutils.cc/h and fileutils_unittests.cc into their own targets.

This will allow for custom implementations downstream.

R=kjellander@webrtc.org, phoglund@webrtc.org
BUG=webrtc:6727
==========

to

==========
Refactor fileutils.cc/h and fileutils_unittests.cc into their own targets.

This will allow for custom implementations downstream.

R=kjellander@webrtc.org, phoglund@webrtc.org
BUG=webrtc:6727

Committed: https://crrev.com/37535bfb7fcb46df9382e6976ce9ac99c3fb1c3e
Cr-Commit-Position: refs/heads/master@{#15423}
==========

[commit-bot: I haz the power, 2016-12-05 14:42:54]

Patchset 8 (id:??) landed as
https://crrev.com/37535bfb7fcb46df9382e6976ce9ac99c3fb1c3e
Cr-Commit-Position: refs/heads/master@{#15423}