Refactor fileutils.cc/h and fileutils_unittests.cc into their own targets.

webrtc/test/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../build/webrtc.gni")
 import("//build/config/ui.gni")
@@ skipping 86 matching lines @@
   deps = [
     ":field_trial",
     ":test_support",
     "../system_wrappers:metrics_default",
     "//testing/gmock",
     "//testing/gtest",
     "//third_party/gflags",
   ]
 }
 
+rtc_source_set("fileutils") {
+  testonly = true
+  sources = [
+    "testsupport/fileutils.cc",
+    "testsupport/fileutils.h",
+  ]
+}
+
+rtc_source_set("fileutils_unittests") {

[kjellander_webrtc, 2016/12/02 14:40:40]

Please move to below test_support_unittests

+  testonly = true
+  sources = [
+    "testsupport/fileutils_unittest.cc",
+  ]
+  deps = [
+    ":default_fileutils",
+    "//testing/gmock",
+    "//testing/gtest",
+  ]
+  if (!build_with_chromium && is_clang) {
+    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
+    suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]

[kjellander_webrtc, 2016/12/02 14:40:40]

Is this one needed? With just so few files, it would be nice to fix the warnings
instead.

+  }
+}
+
 rtc_source_set("test_support") {
   testonly = true
 
   sources = [
     "gmock.h",
     "gtest.h",
-    "testsupport/fileutils.cc",
-    "testsupport/fileutils.h",
     "testsupport/frame_reader.cc",
     "testsupport/frame_reader.h",
     "testsupport/frame_writer.cc",
     "testsupport/frame_writer.h",
     "testsupport/iosfileutils.mm",
     "testsupport/metrics/video_metrics.cc",
     "testsupport/metrics/video_metrics.h",
     "testsupport/mock/mock_frame_reader.h",
     "testsupport/mock/mock_frame_writer.h",
     "testsupport/packet_reader.cc",
     "testsupport/packet_reader.h",
     "testsupport/perf_test.cc",
     "testsupport/perf_test.h",
     "testsupport/trace_to_stderr.cc",
     "testsupport/trace_to_stderr.h",
   ]
 
   deps = [
+    ":fileutils",
     ":video_test_common",
     "../base:gtest_prod",
     "../base:rtc_base_approved",
     "../common_video",
     "../system_wrappers",
     "//testing/gmock",
     "//testing/gtest",
   ]
 
   if (!build_with_chromium && is_clang) {
@@ skipping 54 matching lines @@
 }
 
 rtc_test("test_support_unittests") {
   deps = []
   sources = [
     "fake_network_pipe_unittest.cc",
     "frame_generator_unittest.cc",
     "rtp_file_reader_unittest.cc",
     "rtp_file_writer_unittest.cc",
     "testsupport/always_passing_unittest.cc",
-    "testsupport/fileutils_unittest.cc",
     "testsupport/frame_reader_unittest.cc",
     "testsupport/frame_writer_unittest.cc",
     "testsupport/metrics/video_metrics_unittest.cc",
     "testsupport/packet_reader_unittest.cc",
     "testsupport/perf_test_unittest.cc",
     "testsupport/unittest_utils.h",
   ]
 
   # TODO(jschuh): Bug 1348: fix this warning.
   configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
@@ skipping 11 matching lines @@
   if (is_android) {
     deps += [ "//testing/android/native_test:native_test_support" ]
     shard_timeout = 900
   }
 
   if (is_ios) {
     deps += [ ":test_support_unittests_bundle_data" ]
   }
 
   deps += [
+    ":fileutils_unittests",
     ":test_common",
     ":test_main",
     "../modules/video_capture",
     "//testing/gmock",
     "//testing/gtest",
   ]
 }
 
 rtc_source_set("test_common") {
   testonly = true
@@ skipping 132 matching lines @@
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
 
   deps = [
     ":test_support",
     ":video_test_common",
     "../modules/media_file",
     "//testing/gtest",
   ]
 }