Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2548463002: Add linearly spaced counting histograms (Closed)

Created:
4 years ago by hlundin-webrtc
Modified:
4 years ago
Reviewers:
tommi, åsapersson
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add linearly spaced counting histograms This change adds HistogramFactoryGetCountsLinear and RTC_HISTOGRAM_COUNTS_LINEAR. Note that the default implementation of HistogramFactoryGetCounts in metrics_default.cc also provides a linearly spaced histogram, while the Chrome UMA implementation provides exponentially spaced buckets. BUG=none Committed: https://crrev.com/f29e05d774005eab99956f28b5a384509ea6b295 Cr-Commit-Position: refs/heads/master@{#15367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M webrtc/system_wrappers/include/metrics.h View 2 chunks +11 lines, -0 lines 0 comments Download
M webrtc/system_wrappers/source/metrics_default.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
hlundin-webrtc
Åsa, WDYT about this implementation?
4 years ago (2016-12-01 11:17:20 UTC) #2
åsapersson
lgtm
4 years ago (2016-12-01 12:09:57 UTC) #3
tommi
lgtm
4 years ago (2016-12-01 12:18:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2548463002/1
4 years ago (2016-12-01 12:28:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2548463002/1
4 years ago (2016-12-01 17:57:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 17:58:49 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-01 17:59:00 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f29e05d774005eab99956f28b5a384509ea6b295
Cr-Commit-Position: refs/heads/master@{#15367}

Powered by Google App Engine
This is Rietveld 408576698