Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2547593002: APM: Change 3 UMA metrics to fewer but linearly distributed buckets (Closed)

Created:
4 years ago by hlundin-webrtc
Modified:
4 years ago
Reviewers:
rkaplow, peah-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

APM: Change 3 UMA metrics to fewer but linearly distributed buckets In this change WebRTC.Audio.ApmCaptureInputLevel{Average,Peak} are changed to 64 buckets, while WebRTC.Audio.AgcLevel is changed to 50 buckets. All three are changed to have linear spacing between buckets. Also, the metrics are renamed to avoid stats conflicts because of different bucket schemes: - WebRTC.Audio.AgcLevel -> WebRTC.Audio.AgcSetLevel - WebRTC.Audio.ApmCaptureInputLevelAverage -> WebRTC.Audio.ApmCaptureInputLevelAverageRms - WebRTC.Audio.ApmCaptureInputLevelPeakRms -> WebRTC.Audio.ApmCaptureInputLevelPeakRms BUG=webrtc:6622 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng Committed: https://crrev.com/49715fe3be17d8579586d5bc954d626126d53415 Cr-Commit-Position: refs/heads/master@{#15418}

Patch Set 1 #

Patch Set 2 : Change names for UMA metrics #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M webrtc/modules/audio_processing/agc/agc_manager_direct.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (9 generated)
hlundin-webrtc
peah, rkaplow, Please, take a look at this change.
4 years ago (2016-12-01 18:20:02 UTC) #3
peah-webrtc
On 2016/12/01 18:20:02, hlundin-webrtc wrote: > peah, rkaplow, > > Please, take a look at ...
4 years ago (2016-12-02 14:42:03 UTC) #4
rkaplow
lgtm Is there already a lot of data for these histograms? If so, I'd suggest ...
4 years ago (2016-12-02 20:28:49 UTC) #5
hlundin-webrtc
On 2016/12/02 20:28:49, rkaplow wrote: > lgtm > > Is there already a lot of ...
4 years ago (2016-12-05 09:25:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2547593002/20001
4 years ago (2016-12-05 11:43:28 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 12:13:04 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/49715fe3be17d8579586d5bc954d626126d53415 Cr-Commit-Position: refs/heads/master@{#15418}
4 years ago (2016-12-05 12:13:12 UTC) #16
hlundin-webrtc
4 years ago (2016-12-05 13:11:19 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2548333002/ by henrik.lundin@webrtc.org.

The reason for reverting is: Breaks down-stream dependencies..

Powered by Google App Engine
This is Rietveld 408576698