Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2546863003: Delete unused spreadsort implementation. (Closed)

Created:
4 years ago by nisse-webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused spreadsort implementation. BUG=None Committed: https://crrev.com/fa07b910a90336ff3a5986226352b6590d3eafa9 Cr-Commit-Position: refs/heads/master@{#15417}

Patch Set 1 #

Patch Set 2 : Delete TestSort.cc too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2580 lines) Patch
M webrtc/LICENSE_THIRD_PARTY View 2 chunks +0 lines, -30 lines 0 comments Download
M webrtc/system_wrappers/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
D webrtc/system_wrappers/include/sort.h View 1 chunk +0 lines, -65 lines 0 comments Download
D webrtc/system_wrappers/source/sort.cc View 1 chunk +0 lines, -487 lines 0 comments Download
D webrtc/system_wrappers/source/spreadsortlib/constants.hpp View 1 chunk +0 lines, -42 lines 0 comments Download
D webrtc/system_wrappers/source/spreadsortlib/spreadsort.hpp View 1 chunk +0 lines, -1688 lines 0 comments Download
D webrtc/system_wrappers/test/TestSort/TestSort.cc View 1 1 chunk +0 lines, -266 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
nisse-webrtc
4 years ago (2016-12-02 14:02:14 UTC) #2
kwiberg-webrtc
lgtm! Be sure to run it past the Chromium and Google try bots, though.
4 years ago (2016-12-02 18:17:44 UTC) #4
the sun
On 2016/12/02 18:17:44, kwiberg-webrtc wrote: > lgtm! > > Be sure to run it past ...
4 years ago (2016-12-02 19:12:41 UTC) #5
Henrik Grunell WebRTC
Nice! lgtm
4 years ago (2016-12-05 08:56:50 UTC) #6
nisse-webrtc
On 2016/12/02 18:17:44, kwiberg-webrtc wrote: > Be sure to run it past the Chromium and ...
4 years ago (2016-12-05 08:58:42 UTC) #7
nisse-webrtc
On 2016/12/05 08:58:42, nisse-webrtc wrote: > On 2016/12/02 18:17:44, kwiberg-webrtc wrote: > > > Be ...
4 years ago (2016-12-05 10:41:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2546863003/20001
4 years ago (2016-12-05 10:41:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 11:03:25 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-05 11:03:34 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa07b910a90336ff3a5986226352b6590d3eafa9
Cr-Commit-Position: refs/heads/master@{#15417}

Powered by Google App Engine
This is Rietveld 408576698