AGC: Route clipping parameter from webrtc::Config to AGC

AGC: Route clipping parameter from webrtc::Config to AGC

This change enables experimentation with the clipping minimum level
parameter in the gain control.

BUG=webrtc:6622
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng

Committed: https://crrev.com/bd681b97582b0e1c4afe93b67e8ce84f3bad7dc4
Cr-Commit-Position: refs/heads/master@{#15426}

[hlundin-webrtc, 2016-12-02 15:07:21]

henrik.lundin@webrtc.org changed reviewers:
+ peah@webrtc.org

[hlundin-webrtc, 2016-12-02 15:07:22]

Per, PTAL.

Thanks!

[peah-webrtc, 2016-12-05 09:23:59]

Nice!
We should resolve the issue with how to add information about the experiment
into aecdump recordings. Or can we rely on this being available in accompanied
logs?

https://codereview.webrtc.org/2543753006/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/agc/agc_manager_direct_unittest.cc (right):

https://codereview.webrtc.org/2543753006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/agc/agc_manager_direct_unittest.cc:36: constexpr
int kClippedMin = 165;  // Arbitrary, but different from the default.
Why does this need to differ from the default?

https://codereview.webrtc.org/2543753006/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/2543753006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:1850: std::string
experiments_description =
We should somehow store in APM recordings that this experiment is active. I
think we should either store it as a string describing that this is an
experiment, or store the parameter value in the recording.

[hlundin-webrtc, 2016-12-05 15:01:11]

Thanks for the comments. I uploaded a new PS with fixes. PTAL again.

https://codereview.webrtc.org/2543753006/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/agc/agc_manager_direct_unittest.cc (right):

https://codereview.webrtc.org/2543753006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/agc/agc_manager_direct_unittest.cc:36: constexpr
int kClippedMin = 165;  // Arbitrary, but different from the default.
On 2016/12/05 09:23:59, peah-webrtc wrote:
> Why does this need to differ from the default?

No need, but I think it makes nice testing. If I had it set to the default
value, I would not actually know that my "custom" value had any effect.

https://codereview.webrtc.org/2543753006/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/2543753006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:1850: std::string
experiments_description =
On 2016/12/05 09:23:59, peah-webrtc wrote:
> We should somehow store in APM recordings that this experiment is active. I
> think we should either store it as a string describing that this is an
> experiment, or store the parameter value in the recording. 

Done.

[peah-webrtc, 2016-12-05 15:40:00]

Great!

lgtm with minor nits

https://codereview.webrtc.org/2543753006/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/test/debug_dump_test.cc (right):

https://codereview.webrtc.org/2543753006/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/debug_dump_test.cc:382: // Arbitrarily set
clipping gain to 17, which will never be the dafault.
default

https://codereview.webrtc.org/2543753006/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/debug_dump_test.cc:488: // Arbitrarily set
clipping gain to 17, which will never be the dafault.
default

[hlundin-webrtc, 2016-12-05 15:48:04]

Description was changed from

==========
AGC: Route clipping parameter from webrtc::Config to AGC

This change enables experimentation with the clipping minimum level
parameter in the gain control.

BUG=webrtc:6622
==========

to

==========
AGC: Route clipping parameter from webrtc::Config to AGC

This change enables experimentation with the clipping minimum level
parameter in the gain control.

BUG=webrtc:6622
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
==========

[hlundin-webrtc, 2016-12-05 15:48:20]

Thanks. Fixed, and will commit pending try jobs.

https://codereview.webrtc.org/2543753006/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/test/debug_dump_test.cc (right):

https://codereview.webrtc.org/2543753006/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/debug_dump_test.cc:382: // Arbitrarily set
clipping gain to 17, which will never be the dafault.
On 2016/12/05 15:39:59, peah-webrtc wrote:
> default

Done.

https://codereview.webrtc.org/2543753006/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/debug_dump_test.cc:488: // Arbitrarily set
clipping gain to 17, which will never be the dafault.
On 2016/12/05 15:40:00, peah-webrtc wrote:
> default

Done.

[hlundin-webrtc, 2016-12-05 16:30:16]

The CQ bit was checked by henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-12-05 16:30:16]

The patchset sent to the CQ was uploaded after l-g-t-m from peah@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2543753006/#ps40001 (title:
"Fix a typo")

[commit-bot: I haz the power, 2016-12-05 16:30:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-05 17:08:42]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480955416044220,
"parent_rev": "3879b1b80fc908043de9c0d7ec22014f2f5eacb2", "commit_rev":
"dae146b186ddb95199a88d690c15c12d49370c8a"}

[commit-bot: I haz the power, 2016-12-05 17:08:45]

Description was changed from

==========
AGC: Route clipping parameter from webrtc::Config to AGC

This change enables experimentation with the clipping minimum level
parameter in the gain control.

BUG=webrtc:6622
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
==========

to

==========
AGC: Route clipping parameter from webrtc::Config to AGC

This change enables experimentation with the clipping minimum level
parameter in the gain control.

BUG=webrtc:6622
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
==========

[commit-bot: I haz the power, 2016-12-05 17:08:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-05 17:08:53]

Description was changed from

==========
AGC: Route clipping parameter from webrtc::Config to AGC

This change enables experimentation with the clipping minimum level
parameter in the gain control.

BUG=webrtc:6622
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
==========

to

==========
AGC: Route clipping parameter from webrtc::Config to AGC

This change enables experimentation with the clipping minimum level
parameter in the gain control.

BUG=webrtc:6622
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng

Committed: https://crrev.com/bd681b97582b0e1c4afe93b67e8ce84f3bad7dc4
Cr-Commit-Position: refs/heads/master@{#15426}
==========

[commit-bot: I haz the power, 2016-12-05 17:08:54]

Patchset 3 (id:??) landed as
https://crrev.com/bd681b97582b0e1c4afe93b67e8ce84f3bad7dc4
Cr-Commit-Position: refs/heads/master@{#15426}