AGC: Route clipping parameter from webrtc::Config to AGC

webrtc/modules/audio_processing/agc/agc_manager_direct_unittest.cc

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 15 matching lines @@
 using ::testing::SetArgPointee;
 using ::testing::SetArgReferee;
 
 namespace webrtc {
 namespace {
 
 const int kSampleRateHz = 32000;
 const int kNumChannels = 1;
 const int kSamplesPerChannel = kSampleRateHz / 100;
 const int kInitialVolume = 128;
+constexpr int kClippedMin = 165;  // Arbitrary, but different from the default.

[peah-webrtc, 2016/12/05 09:23:59]

Why does this need to differ from the default?

[hlundin-webrtc, 2016/12/05 15:01:11]

No need, but I think it makes nice testing. If I had it set to the default
value, I would not actually know that my "custom" value had any effect.

 const float kAboveClippedThreshold = 0.2f;
 
 class TestVolumeCallbacks : public VolumeCallbacks {
  public:
   TestVolumeCallbacks() : volume_(0) {}
   void SetMicVolume(int volume) override { volume_ = volume; }
   int GetMicVolume() override { return volume_; }
 
  private:
   int volume_;
 };
 
 }  // namespace
 
 class AgcManagerDirectTest : public ::testing::Test {
  protected:
   AgcManagerDirectTest()
-      : agc_(new MockAgc), manager_(agc_, &gctrl_, &volume_, kInitialVolume) {
+      : agc_(new MockAgc),
+        manager_(agc_, &gctrl_, &volume_, kInitialVolume, kClippedMin) {
     ExpectInitialize();
     manager_.Initialize();
   }
 
   void FirstProcess() {
     EXPECT_CALL(*agc_, Reset());
     EXPECT_CALL(*agc_, GetRmsErrorDb(_)).WillOnce(Return(false));
     CallProcess(1);
   }
 
@@ skipping 434 matching lines @@
   EXPECT_EQ(225, volume_.GetMicVolume());
 }
 
 TEST_F(AgcManagerDirectTest, ClippingLoweringIsLimited) {
   SetVolumeAndProcess(180);
 
   EXPECT_CALL(*agc_, AnalyzePreproc(_, _))
       .WillOnce(Return(kAboveClippedThreshold));
   EXPECT_CALL(*agc_, Reset()).Times(1);
   CallPreProc(1);
-  EXPECT_EQ(170, volume_.GetMicVolume());
+  EXPECT_EQ(kClippedMin, volume_.GetMicVolume());
 
   EXPECT_CALL(*agc_, AnalyzePreproc(_, _))
       .WillRepeatedly(Return(kAboveClippedThreshold));
   EXPECT_CALL(*agc_, Reset()).Times(0);
   CallPreProc(1000);
-  EXPECT_EQ(170, volume_.GetMicVolume());
+  EXPECT_EQ(kClippedMin, volume_.GetMicVolume());
 }
 
 TEST_F(AgcManagerDirectTest, ClippingMaxIsRespectedWhenEqualToLevel) {
   SetVolumeAndProcess(255);
 
   EXPECT_CALL(*agc_, AnalyzePreproc(_, _))
       .WillOnce(Return(kAboveClippedThreshold));
   EXPECT_CALL(*agc_, Reset()).Times(1);
   CallPreProc(1);
   EXPECT_EQ(240, volume_.GetMicVolume());
@@ skipping 57 matching lines @@
       .WillOnce(Return(kAboveClippedThreshold));
   EXPECT_CALL(*agc_, Reset()).Times(1);
   CallPreProc(1);
   EXPECT_EQ(180, volume_.GetMicVolume());
 
   CallPreProc(300);
   EXPECT_CALL(*agc_, AnalyzePreproc(_, _))
       .WillOnce(Return(kAboveClippedThreshold));
   EXPECT_CALL(*agc_, Reset()).Times(1);
   CallPreProc(1);
-  EXPECT_EQ(170, volume_.GetMicVolume());
+  EXPECT_EQ(kClippedMin, volume_.GetMicVolume());
 
   // Current level is now at the minimum, but the maximum allowed level still
   // has more to decrease.
   CallPreProc(300);
   EXPECT_CALL(*agc_, AnalyzePreproc(_, _))
       .WillOnce(Return(kAboveClippedThreshold));
   CallPreProc(1);
 
   CallPreProc(300);
   EXPECT_CALL(*agc_, AnalyzePreproc(_, _))
@@ skipping 74 matching lines @@
   FirstProcess();
 
   EXPECT_CALL(*agc_, GetRmsErrorDb(_))
       .WillRepeatedly(DoAll(SetArgPointee<0>(30), Return(true)));
   volume_.SetMicVolume(0);
   CallProcess(10);
   EXPECT_EQ(0, volume_.GetMicVolume());
 }
 
 }  // namespace webrtc