Add vector<uint8_t> to Base64 decoded data types.

Add vector<uint8_t> to Base64 decoded data types.

This is a prerequisite to decode fmtp sprop-parameter-sets into
the right encoding for H264SpsPpsTracker.

# Legal requires us to keep the original license header.
NOPRESUBMIT=true
BUG=webrtc:5948
Committed: https://crrev.com/8fc0c4c32ff6ba1dc0939c5ea34bc56e5b21cbc9
Cr-Commit-Position: refs/heads/master@{#15604}

[johan, 2016-11-30 15:14:56]

johan@webrtc.org changed reviewers:
+ sprang@google.com

[johan, 2016-11-30 15:14:57]

Note: this file is not under the WebRTC license. From a technical view modifying
the Base64 decoder as proposed in this cl would be the clean approach. If that
is not possible due to legal reasons we can create a not so clean workaround.

[johan, 2016-12-01 18:18:31]

johan@webrtc.org changed reviewers:
+ blum@webrtc.org

[johan, 2016-12-01 18:18:31]

blum@ Files in this CL have a specific copyright header, not the standard webrtc
copyright header.
Can we make code changes to these files from a legal perspective?

[johan, 2016-12-13 14:13:35]

Description was changed from

==========
Add vector<uint8_t> to Base64 decoded data types.

This is a prerequisite to decode fmtp sprop-parameter-sets into
the right encoding for H264SpsPpsTracker.

BUG=webrtc:5948
==========

to

==========
Add vector<uint8_t> to Base64 decoded data types.

This is a prerequisite to decode fmtp sprop-parameter-sets into
the right encoding for H264SpsPpsTracker.

BUG=webrtc:5948
==========

[johan, 2016-12-13 14:13:35]

johan@webrtc.org changed reviewers:
- blum@webrtc.org

[johan, 2016-12-13 14:14:58]

Got legal clearance through Niklas Blum.

[johan, 2016-12-13 14:19:22]

Erik PTAL and maybe find an owner.

[johan, 2016-12-13 14:33:56]

The CQ bit was checked by johan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 14:34:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-13 14:36:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 14:36:50]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11381)

[sprang_webrtc, 2016-12-14 08:43:04]

sprang@webrtc.org changed reviewers:
+ perkj@webrtc.org, sprang@webrtc.org

[sprang_webrtc, 2016-12-14 08:43:04]

lgtm with nit
perkj@, can you have look as owner?

https://codereview.webrtc.org/2539153002/diff/1/webrtc/base/base64.cc
File webrtc/base/base64.cc (right):

https://codereview.webrtc.org/2539153002/diff/1/webrtc/base/base64.cc#newcode210
webrtc/base/base64.cc:210: data_used);
It's actually allowed to write DecodeFromArrayTemplate<vector<uint8_t>> now.
Same above.

[perkj_webrtc, 2016-12-14 09:18:17]

lgtm

https://codereview.webrtc.org/2539153002/diff/1/webrtc/base/base64.h
File webrtc/base/base64.h (right):

https://codereview.webrtc.org/2539153002/diff/1/webrtc/base/base64.h#newcode64
webrtc/base/base64.h:64: static bool DecodeFromArray(const char* data, size_t
len, DecodeFlags flags,
Remove this one?

https://codereview.webrtc.org/2539153002/diff/1/webrtc/base/base64.h#newcode68
webrtc/base/base64.h:68: DecodeFlags flags,
run git cl format?

[perkj_webrtc, 2016-12-14 09:18:17]

lgtm

[johan, 2016-12-14 10:04:39]

johan@webrtc.org changed reviewers:
- sprang@google.com

[johan, 2016-12-14 10:21:16]

https://codereview.webrtc.org/2539153002/diff/1/webrtc/base/base64.cc
File webrtc/base/base64.cc (right):

https://codereview.webrtc.org/2539153002/diff/1/webrtc/base/base64.cc#newcode210
webrtc/base/base64.cc:210: data_used);
On 2016/12/14 08:43:04, språng wrote:
> It's actually allowed to write DecodeFromArrayTemplate<vector<uint8_t>> now.
> Same above.

Done

https://codereview.webrtc.org/2539153002/diff/1/webrtc/base/base64.h
File webrtc/base/base64.h (right):

https://codereview.webrtc.org/2539153002/diff/1/webrtc/base/base64.h#newcode64
webrtc/base/base64.h:64: static bool DecodeFromArray(const char* data, size_t
len, DecodeFlags flags,
On 2016/12/14 09:18:17, perkj_webrtc wrote:
> Remove this one?

This one currently in use. I plan to remove at least one user of this function
with a follow-up CL.

https://codereview.webrtc.org/2539153002/diff/1/webrtc/base/base64.h#newcode68
webrtc/base/base64.h:68: DecodeFlags flags,
On 2016/12/14 09:18:17, perkj_webrtc wrote:
> run git cl format?

This *is* actually the result of git cl format. We run "git cl format --full" on
base64.cc and base64.h in a follow up cl. But I prefer not to clutter this CL
with reformatting entire files.

[johan, 2016-12-14 10:25:40]

Note on presubmit checks: legal states it is important not to change the license
header.

[johan, 2016-12-14 10:40:44]

The CQ bit was checked by johan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 10:40:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-14 10:44:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 10:44:02]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11414)

[johan, 2016-12-14 10:46:00]

Description was changed from

==========
Add vector<uint8_t> to Base64 decoded data types.

This is a prerequisite to decode fmtp sprop-parameter-sets into
the right encoding for H264SpsPpsTracker.

BUG=webrtc:5948
==========

to

==========
Add vector<uint8_t> to Base64 decoded data types.

This is a prerequisite to decode fmtp sprop-parameter-sets into
the right encoding for H264SpsPpsTracker.

NOPRESUBMIT=true
BUG=webrtc:5948
==========

[johan, 2016-12-14 10:46:54]

Description was changed from

==========
Add vector<uint8_t> to Base64 decoded data types.

This is a prerequisite to decode fmtp sprop-parameter-sets into
the right encoding for H264SpsPpsTracker.

NOPRESUBMIT=true
BUG=webrtc:5948
==========

to

==========
Add vector<uint8_t> to Base64 decoded data types.

This is a prerequisite to decode fmtp sprop-parameter-sets into
the right encoding for H264SpsPpsTracker.

# Change of license header is not allowed.
NOPRESUBMIT=true
BUG=webrtc:5948
==========

[johan, 2016-12-14 10:47:37]

Description was changed from

==========
Add vector<uint8_t> to Base64 decoded data types.

This is a prerequisite to decode fmtp sprop-parameter-sets into
the right encoding for H264SpsPpsTracker.

# Change of license header is not allowed.
NOPRESUBMIT=true
BUG=webrtc:5948
==========

to

==========
Add vector<uint8_t> to Base64 decoded data types.

This is a prerequisite to decode fmtp sprop-parameter-sets into
the right encoding for H264SpsPpsTracker.

# Legal requires us to not change the license header.
NOPRESUBMIT=true
BUG=webrtc:5948
==========

[johan, 2016-12-14 10:48:27]

Description was changed from

==========
Add vector<uint8_t> to Base64 decoded data types.

This is a prerequisite to decode fmtp sprop-parameter-sets into
the right encoding for H264SpsPpsTracker.

# Legal requires us to not change the license header.
NOPRESUBMIT=true
BUG=webrtc:5948
==========

to

==========
Add vector<uint8_t> to Base64 decoded data types.

This is a prerequisite to decode fmtp sprop-parameter-sets into
the right encoding for H264SpsPpsTracker.

# Legal requires us to keep the original license header.
NOPRESUBMIT=true
BUG=webrtc:5948
==========

[johan, 2016-12-14 11:58:36]

The CQ bit was checked by johan@webrtc.org

[johan, 2016-12-14 11:58:36]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org,
perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2539153002/#ps20001 (title:
"Resolve template usage style nits.")

[commit-bot: I haz the power, 2016-12-14 11:58:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-14 12:12:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481716716055710,
"parent_rev": "e3e2561e0ee981d8184fe49c04dc4ff143cf9b6a", "commit_rev":
"2de3ec1e154deb1ba0d31f5969960f221cabf684"}

[commit-bot: I haz the power, 2016-12-14 12:12:59]

Description was changed from

==========
Add vector<uint8_t> to Base64 decoded data types.

This is a prerequisite to decode fmtp sprop-parameter-sets into
the right encoding for H264SpsPpsTracker.

# Legal requires us to keep the original license header.
NOPRESUBMIT=true
BUG=webrtc:5948
==========

to

==========
Add vector<uint8_t> to Base64 decoded data types.

This is a prerequisite to decode fmtp sprop-parameter-sets into
the right encoding for H264SpsPpsTracker.

# Legal requires us to keep the original license header.
NOPRESUBMIT=true
BUG=webrtc:5948

Review-Url: https://codereview.webrtc.org/2539153002
==========

[commit-bot: I haz the power, 2016-12-14 12:13:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 12:13:12]

Description was changed from

==========
Add vector<uint8_t> to Base64 decoded data types.

This is a prerequisite to decode fmtp sprop-parameter-sets into
the right encoding for H264SpsPpsTracker.

# Legal requires us to keep the original license header.
NOPRESUBMIT=true
BUG=webrtc:5948

Review-Url: https://codereview.webrtc.org/2539153002
==========

to

==========
Add vector<uint8_t> to Base64 decoded data types.

This is a prerequisite to decode fmtp sprop-parameter-sets into
the right encoding for H264SpsPpsTracker.

# Legal requires us to keep the original license header.
NOPRESUBMIT=true
BUG=webrtc:5948

Committed: https://crrev.com/8fc0c4c32ff6ba1dc0939c5ea34bc56e5b21cbc9
Cr-Commit-Position: refs/heads/master@{#15604}
==========

[commit-bot: I haz the power, 2016-12-14 12:13:13]

Patchset 2 (id:??) landed as
https://crrev.com/8fc0c4c32ff6ba1dc0939c5ea34bc56e5b21cbc9
Cr-Commit-Position: refs/heads/master@{#15604}